Give an option to override the number of shards in BQ streaming insert addresses#25569
Give an option to override the number of shards in BQ streaming insert addresses#25569jrmccluskey merged 4 commits intoapache:masterfrom
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report
@@ Coverage Diff @@
## master #25569 +/- ##
==========================================
- Coverage 72.80% 72.75% -0.05%
==========================================
Files 750 751 +1
Lines 99314 99405 +91
==========================================
+ Hits 72308 72325 +17
- Misses 25644 25718 +74
Partials 1362 1362
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
A friendly reminder for code review @jrmccluskey @pabloem |
|
Run Python PreCommit |
| ignore_insert_ids, | ||
| ignore_unknown_columns, | ||
| with_auto_sharding, | ||
| num_streaming_keys, |
There was a problem hiding this comment.
Is there a reason you don't have the old default value set here? It would help mitigate issues with backwards compatibility for users who aren't using the test_client and max_retries args either
jrmccluskey
left a comment
There was a problem hiding this comment.
LGTM from a Python code standpoint, waiting on @pabloem for a look over from an IO standpoint
|
Friendly reminder for review~ @pabloem |
1 similar comment
|
Friendly reminder for review~ @pabloem |
|
Another friendly reminder for review~ @pabloem |
|
Looks like Pablo isn't going to get to it, but based on what I'm seeing and the testing I'm comfortable merging. Thank you for your contribution, and sorry for the wait! |
|
Thank you @jrmccluskey ! |
…t addresses (apache#25569) * Give an option to override the default number of shards in BQ streaming inserts * Fix unit test * Fix lint error * Address comments
Give an option to override the default number of shards in BQ streaming inserts. fixes #20420
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.