[BEAM-12160] Add TODO for fixing the warning#14516
[BEAM-12160] Add TODO for fixing the warning#14516aromanenko-dev merged 1 commit intoapache:masterfrom
Conversation
|
r: @kennknowles |
|
Run Java PreCommit |
|
I would like to merge this with multiple commits and not flattening them. I would like the formatting change to be a separate commit from the others. It is OK if it come later in topological order, but would you mind organizing the PR into commits that can be merged without squashing? |
|
(mislick) |
There are 3 commits in this PR, where the last commit is the format changes. |
|
It looks that this PR contradicts with another one #14373, that was submitted a while ago and was waiting for review. Additionally to unifying a build part for the module, it allows to run TPC-DS benchmark with SparkRunner as well. Can we merge #14373 before and then adjust this PR accordingly? |
|
I merged Alexey's PR before because he opened the PR first and I had almost finished reviewing it. |
|
To avoid the similar situations in the future, I'd like to suggest to sync for ongoing and future work for this module here or on dev@. In the same time, I added a new component |
|
The conflicts should be no problem - just keep the version from |
|
I had thought from the change description "Address warning" that the middle commit should be squashed. But I can see that it should perhaps be topologically before using |
|
Thanks for mentioning the existing changes, Ismael and Alexey. Let me rebase and to see whether we still have additional changes. |
sdks/java/testing/tpcds/build.gradle
Outdated
There was a problem hiding this comment.
@iemejia @aromanenko-dev Do we want to publish this package during release?
There was a problem hiding this comment.
Hmm, good catch. We do this for Nexmark but I don't think it's needed as published artifacts.
@iemejia wdyt?
There was a problem hiding this comment.
I think publishing them is better to enable other parties to reproduce it outside of Beam. Also adding an extra module probably does not add too much extra weight to the release process.
There was a problem hiding this comment.
Ack. So the only difference is I added 2 TODO to indicate addressing warngings.
|
Run Java PreCommit |
|
The Workflow run is cancelling this PR. It is an earlier duplicate of 2173354 run. |
boyuanzz
changed the title
|
Run Java PreCommit |
3 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
4 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.