[BEAM-10991] Revert "[BEAM-8543] Dataflow streaming timers are not strictly time ordered when set earlier mid-bundle (#11924)"#12980
Merged
kennknowles merged 1 commit intoapache:masterfrom Oct 1, 2020
Conversation
…rdered when set earlier mid-bundle (apache#11924)" This reverts commit 88acc52. There is a bug in this commit that causes deleted timers to not clear their watermark holds, resulting in stuck pipelines. See https://issues.apache.org/jira/browse/BEAM-10991
Member
Author
|
CC @robinyqiu we will want to cherrypick this |
Contributor
|
LGTM |
aaltay
approved these changes
Sep 30, 2020
Member
|
/cc @robinyqiu - This change also needs to go to the release branch. |
Member
Author
|
run dataflow validatesrunner |
robinyqiu
pushed a commit
that referenced
this pull request
Oct 5, 2020
[BEAM-10991] Cherrypick #12980 to 2.25.0: Revert "[BEAM-8543] Dataflow streaming timers are not strictly time ordered when set earlier mid-bundle (#11924)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 88acc52.
There is a bug in this commit that causes deleted timers to not clear their
watermark holds, resulting in stuck pipelines. See
https://issues.apache.org/jira/browse/BEAM-10991
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.