Skip to content

ARROW-10286: [C++][FlightRPC] Make CMake output less confusing #8442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidavidm wants to merge 1 commit into from
Closed

ARROW-10286: [C++][FlightRPC] Make CMake output less confusing #8442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 33 additions & 24 deletions cpp/src/arrow/flight/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,34 +69,43 @@ string(REPLACE "-Werror " " " CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")

# Probe the version of gRPC being used to see if it supports disabling server
# verification when using TLS.
message(STATUS "Checking support for TlsCredentialsOptions...")
get_property(CURRENT_INCLUDE_DIRECTORIES
DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
PROPERTY INCLUDE_DIRECTORIES)
try_compile(HAS_GRPC_132 ${CMAKE_CURRENT_BINARY_DIR}/try_compile SOURCES
"${CMAKE_CURRENT_SOURCE_DIR}/try_compile/check_tls_opts_132.cc"
CMAKE_FLAGS "-DINCLUDE_DIRECTORIES=${CURRENT_INCLUDE_DIRECTORIES}"
LINK_LIBRARIES gRPC::grpc
OUTPUT_VARIABLE TSL_CREDENTIALS_OPTIONS_CHECK_OUTPUT CXX_STANDARD 11)

if(HAS_GRPC_132)
message(STATUS "TlsCredentialsOptions found in grpc::experimental.")
add_definitions(-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc::experimental)
else()
message(STATUS "TlsCredentialsOptions not found in grpc::experimental.")
message(STATUS "Build output: ${TSL_CREDENTIALS_OPTIONS_CHECK_OUTPUT}")

try_compile(HAS_GRPC_127 ${CMAKE_CURRENT_BINARY_DIR}/try_compile SOURCES
"${CMAKE_CURRENT_SOURCE_DIR}/try_compile/check_tls_opts_127.cc"
if(NOT DEFINED HAS_GRPC_132)
message(STATUS "Checking support for TlsCredentialsOptions...")
get_property(CURRENT_INCLUDE_DIRECTORIES
DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
PROPERTY INCLUDE_DIRECTORIES)
try_compile(HAS_GRPC_132 ${CMAKE_CURRENT_BINARY_DIR}/try_compile SOURCES
"${CMAKE_CURRENT_SOURCE_DIR}/try_compile/check_tls_opts_132.cc"
CMAKE_FLAGS "-DINCLUDE_DIRECTORIES=${CURRENT_INCLUDE_DIRECTORIES}"
LINK_LIBRARIES gRPC::grpc
OUTPUT_VARIABLE TSL_CREDENTIALS_OPTIONS_CHECK_OUTPUT CXX_STANDARD 11)

if(HAS_GRPC_127)
message(STATUS "TlsCredentialsOptions found in grpc_impl::experimental.")
add_definitions(-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc_impl::experimental)
if(HAS_GRPC_132)
message(STATUS "TlsCredentialsOptions found in grpc::experimental.")
add_definitions(-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc::experimental)
else()
message(STATUS "TlsCredentialsOptions not found in grpc_impl::experimental.")
message(STATUS "Build output: ${TSL_CREDENTIALS_OPTIONS_CHECK_OUTPUT}")
message(STATUS "TlsCredentialsOptions not found in grpc::experimental.")
message(DEBUG "Build output:")
list(APPEND CMAKE_MESSAGE_INDENT "check_tls_opts_132.cc: ")
message(DEBUG ${TSL_CREDENTIALS_OPTIONS_CHECK_OUTPUT})
list(POP_BACK CMAKE_MESSAGE_INDENT)

try_compile(HAS_GRPC_127 ${CMAKE_CURRENT_BINARY_DIR}/try_compile SOURCES
"${CMAKE_CURRENT_SOURCE_DIR}/try_compile/check_tls_opts_127.cc"
CMAKE_FLAGS "-DINCLUDE_DIRECTORIES=${CURRENT_INCLUDE_DIRECTORIES}"
OUTPUT_VARIABLE TSL_CREDENTIALS_OPTIONS_CHECK_OUTPUT CXX_STANDARD 11)

if(HAS_GRPC_127)
message(STATUS "TlsCredentialsOptions found in grpc_impl::experimental.")
add_definitions(
-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc_impl::experimental)
else()
message(STATUS "TlsCredentialsOptions not found in grpc_impl::experimental.")
message(DEBUG "Build output:")
list(APPEND CMAKE_MESSAGE_INDENT "check_tls_opts_127.cc: ")
message(DEBUG ${TSL_CREDENTIALS_OPTIONS_CHECK_OUTPUT})
list(POP_BACK CMAKE_MESSAGE_INDENT)
endif()
endif()
endif()

Expand Down