ARROW-10002: [Rust] Remove default fn from PrimitiveArrayOps#8206
Closed
BatmanAoD wants to merge 8 commits intoapache:masterfrom
Closed
ARROW-10002: [Rust] Remove default fn from PrimitiveArrayOps#8206BatmanAoD wants to merge 8 commits intoapache:masterfrom
default fn from PrimitiveArrayOps#8206BatmanAoD wants to merge 8 commits intoapache:masterfrom
Conversation
BatmanAoD
commented
Sep 16, 2020
andygrove
approved these changes
Sep 16, 2020
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
Thanks @BatmanAoD this LGTM but I would like to see reviews from other other Rust contributors before merging this, in case there are subtle details that I am missing. Perhaps @paddyhoran or @nevi-me could take a look too?
paddyhoran
approved these changes
Sep 17, 2020
Contributor
paddyhoran
left a comment
paddyhoran
left a comment
There was a problem hiding this comment.
Nice. LGTM. Thanks @BatmanAoD
Member
|
@BatmanAoD Could you rebase against master (not merge) and I can merge this. |
BatmanAoD
force-pushed
the
IndexViaPrimitive
branch
2 times, most recently
from
93ca62a to
c906467
Compare
BatmanAoD
force-pushed
the
IndexViaPrimitive
branch
from
84b04b8 to
7be32f2
Compare
Member
|
Test failures are unrelated (conda integration tests) |
Member
|
🎉 this is highly appreciated, and the API is also easier to work with. |
Member
|
Just found out this... Nice work @BatmanAoD ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
This is based on my proof-of-concept solution.