Skip to content

ARROW-8598: [Rust] simd_compare_op creates buffer of incorrect length#7043

Closed
paddyhoran wants to merge 3 commits intoapache:masterfrom
paddyhoran:simd-compare-fix
Closed

ARROW-8598: [Rust] simd_compare_op creates buffer of incorrect length#7043
paddyhoran wants to merge 3 commits intoapache:masterfrom
paddyhoran:simd-compare-fix

Conversation

@paddyhoran
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

@paddyhoran
Copy link
Copy Markdown
Contributor Author

paddyhoran commented Apr 27, 2020

cc @yordan-pavlov

@paddyhoran paddyhoran requested review from andygrove and nevi-me April 27, 2020 03:10
@nevi-me
Copy link
Copy Markdown
Contributor

nevi-me commented Apr 27, 2020

@paddyhoran do we need to worry about this, as it'd get removed by #7037?

@paddyhoran
Copy link
Copy Markdown
Contributor Author

@nevi-me when I added this fix I hadn't looked at your PR removing packed_simd. I introduced this bug so wanted to get a fix posted.

Also, I wasn't sure what your timelines were for #7037.

Copy link
Copy Markdown
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I still need to do more work on the PR to remove packed_simd, so that might take some more days. Happy to proceed with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants