Skip to content

ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly#7024

Closed
andygrove wants to merge 4 commits intoapache:masterfrom
andygrove:rust-nightly-2020-04-22
Closed

ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly#7024
andygrove wants to merge 4 commits intoapache:masterfrom
andygrove:rust-nightly-2020-04-22

Conversation

@andygrove
Copy link
Copy Markdown
Member

Now that Rust 1.43.0 is released, we should upgrade to 1.44 nightly. It looks like there were changes in rustfmt rules.

@github-actions
Copy link
Copy Markdown

@paddyhoran
Copy link
Copy Markdown
Contributor

paddyhoran commented Apr 24, 2020

CI is failing again, I thought this was fixed by #7010

@nevi-me
Copy link
Copy Markdown
Contributor

nevi-me commented Apr 24, 2020

@paddyhoran we might have to try a different nightly, as sometimes a day's version might have no rustfmt. The change I made in that PR installs a nightly version, I don't know how to make GHA install a stable version of rustfmt

@markhildreth
Copy link
Copy Markdown
Contributor

markhildreth commented Apr 24, 2020

@andygrove I think there is going to be more to this than this PR. The "nightly-2019-11-14" string can be found in a few places, including some of the build scripts (notice that the workflows run for this PR are still called "2019-11-14").

@nevi-me @paddyhoran The problem with this error seems to be that the change was only made in rust-toolchain. As a result, the GHA workflows will still build a Rust environment with a nightly-2019-11-14 toolchain. When cargo attempts to build, it will notice that the toolchain is out of date with the rust-toolchain file, and attempt to pull the new toolchain on-the-fly. However, it doesn't necessarily pull rustfmt when this occurs.

installed toolchains
--------------------

stable-x86_64-pc-windows-msvc
nightly-2019-11-14-x86_64-pc-windows-msvc

active toolchain
----------------

nightly-2019-11-14-x86_64-pc-windows-msvc (directory override for '\\?\D:\a\arrow\arrow')
rustc 1.41.0-nightly (ded5ee001 2019-11-13)

+ mkdir -p /d/a/arrow/arrow/build/rust
+ pushd /d/a/arrow/arrow/rust
/d/a/arrow/arrow/rust /d/a/arrow/arrow
+ RUSTFLAGS='-D warnings'
+ cargo build --all-targets
info: syncing channel updates for 'nightly-2020-04-22-x86_64-pc-windows-msvc'
info: latest update on 2020-04-22, rust version 1.44.0-nightly (45d050cde 2020-04-21)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'

@nevi-me
Copy link
Copy Markdown
Contributor

nevi-me commented Apr 28, 2020

@andygrove the failure doesn't make sense to me. On my machine, the relevant file is formatted correctly. @jorisvandenbossche we'll fix the lint CI failure here.


@markhildreth a bad case of copy-pasta, apologies

@markhildreth
Copy link
Copy Markdown
Contributor

markhildreth commented Apr 28, 2020

@nevi-me there was a change (d094631) to that file on master checked in after this branch was created. Rebasing a local branch onto master should cause the error to appear locally.

@nevi-me
Copy link
Copy Markdown
Contributor

nevi-me commented Apr 28, 2020

Thanks @markhildreth, I didn't see that the branch wasn't rebased into master. We should be fine now.

@nevi-me nevi-me force-pushed the rust-nightly-2020-04-22 branch from 5e7cf58 to 3d610ec Compare April 28, 2020 17:13
nevi-me added a commit to nevi-me/ursabot that referenced this pull request Apr 28, 2020
@kszucs
Copy link
Copy Markdown
Member

kszucs commented Apr 29, 2020

@nevi-me you can ignore the failed ursabot builder, I've turned it off.

Copy link
Copy Markdown
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants