ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly#7024
ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly#7024andygrove wants to merge 4 commits intoapache:masterfrom
Conversation
|
CI is failing again, I thought this was fixed by #7010 |
|
@paddyhoran we might have to try a different nightly, as sometimes a day's version might have no rustfmt. The change I made in that PR installs a nightly version, I don't know how to make GHA install a stable version of rustfmt |
|
@andygrove I think there is going to be more to this than this PR. The "nightly-2019-11-14" string can be found in a few places, including some of the build scripts (notice that the workflows run for this PR are still called "2019-11-14"). @nevi-me @paddyhoran The problem with this error seems to be that the change was only made in rust-toolchain. As a result, the GHA workflows will still build a Rust environment with a nightly-2019-11-14 toolchain. When cargo attempts to build, it will notice that the toolchain is out of date with the |
|
@andygrove the failure doesn't make sense to me. On my machine, the relevant file is formatted correctly. @jorisvandenbossche we'll fix the lint CI failure here. @markhildreth a bad case of copy-pasta, apologies |
|
Thanks @markhildreth, I didn't see that the branch wasn't rebased into master. We should be fine now. |
5e7cf58 to
3d610ec
Compare
This would correspond to apache/arrow#7024
|
@nevi-me you can ignore the failed ursabot builder, I've turned it off. |
Now that Rust 1.43.0 is released, we should upgrade to 1.44 nightly. It looks like there were changes in rustfmt rules.