ARROW-6461: [Java] Prevent EchoServer from closing the client socket after writing#5288
Closed
BryanCutler wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6461: [Java] Prevent EchoServer from closing the client socket after writing#5288BryanCutler wants to merge 1 commit intoapache:masterfrom
BryanCutler wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@tianchen92 and @emkornfield , this fixed the error for me although I could only recreate the issue with the changes in #5229 with the 8 byte prefix on (by default). If you want you can try it out in your branch and see if we pass tests first, or if this looks ok we could merge this and then rebase your branch. |
tianchen92
approved these changes
Sep 5, 2019
Contributor
tianchen92
left a comment
tianchen92
left a comment
There was a problem hiding this comment.
Thanks @BryanCutler , I think we could get this merged once build pass, and I could rebase on my branch later.
Codecov Report
@@ Coverage Diff @@
## master #5288 +/- ##
=========================================
Coverage ? 89.71%
=========================================
Files ? 693
Lines ? 104695
Branches ? 0
=========================================
Hits ? 93926
Misses ? 10769
Partials ? 0Continue to review full report at Codecov.
|
Member
Author
|
merged to master |
tianchen92
pushed a commit
to tianchen92/arrow
that referenced
this pull request
Sep 6, 2019
…after writing This change prevents a race condition where the `EchoServer` closes the client socket immediately after writing batches and the client may have not finished reading from the socket. The socket was being closed in three places: `ArrowStreamReader.close()` and `ArrowStreamWriter.close()` when being AutoClosed, and when the `ClientConnection` went out of scope. The race condition was prevalent in apache#5229 and consitently failing the `EchoServerTests.basicTest`. Closes apache#5288 from BryanCutler/java-EchoServer-prevent-close-6461 and squashes the following commits: 3763cbc <Bryan Cutler> Prevent EchoServer from closing the client socket after writing batches Authored-by: Bryan Cutler <cutlerb@gmail.com> Signed-off-by: Bryan Cutler <cutlerb@gmail.com>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…after writing This change prevents a race condition where the `EchoServer` closes the client socket immediately after writing batches and the client may have not finished reading from the socket. The socket was being closed in three places: `ArrowStreamReader.close()` and `ArrowStreamWriter.close()` when being AutoClosed, and when the `ClientConnection` went out of scope. The race condition was prevalent in apache#5229 and consitently failing the `EchoServerTests.basicTest`. Closes apache#5288 from BryanCutler/java-EchoServer-prevent-close-6461 and squashes the following commits: 3763cbc <Bryan Cutler> Prevent EchoServer from closing the client socket after writing batches Authored-by: Bryan Cutler <cutlerb@gmail.com> Signed-off-by: Bryan Cutler <cutlerb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents a race condition where the
EchoServercloses the client socket immediately after writing batches and the client may have not finished reading from the socket. The socket was being closed in three places:ArrowStreamReader.close()andArrowStreamWriter.close()when being AutoClosed, and when theClientConnectionwent out of scope. The race condition was prevalent in #5229 and consitently failing theEchoServerTests.basicTest.