Skip to content

Conversation

@rok
Copy link
Member

@rok rok commented Jan 30, 2026

See #48619 (comment)

Rationale for this change

Fix CI failures

What changes are included in this PR?

Tests are made more general to allow for Pandas 2 and Pandas 3 style string types

Are these changes tested?

By CI

Are there any user-facing changes?

No

@rok rok changed the title [MINOR] Fix doctests failing on pandas 3 string types examples MINOR: [Doc][CI] Fix doctests failing on pandas 3 string types examples Jan 30, 2026
@apache apache deleted a comment from github-actions bot Jan 30, 2026
@rok rok force-pushed the fix_doctest_issues branch from 060eab3 to f14ade1 Compare January 30, 2026 16:27
7 baz
dtype: category
Categories (3, object): ['foo', 'bar', 'baz']
Categories (3, ...): ['foo', 'bar', 'baz']
Copy link
Member

@jorisvandenbossche jorisvandenbossche Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think if we know the doctests will run on an instance with pandas>=3, I would just update those to use pandas 3 output, because that will be less confusing for people reading the docs ("what do those 3 dots mean here?").

Suggested change
Categories (3, ...): ['foo', 'bar', 'baz']
Categories (3, str): ['foo', 'bar', 'baz']

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to start testing on Pandas 3 exclusively? I believe we have both testing now. (One is not triggered for this PR because the scope is smaller)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do agree to stop doctest on Pandas 2.x.y then we should also update CI appropriately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For general tests (unit tests) we certainly have to test with various pandas versions (i.e. whichever range we claim to support), but personally I think for doctests it is perfectly fine to just have those passing in one specific environment (they are not meant as actual proper tests, but only to ensure the docs are correct and kept up to date)

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 30, 2026
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 30, 2026
@rok rok force-pushed the fix_doctest_issues branch from 4d0a733 to c84c874 Compare January 31, 2026 07:31
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 31, 2026
@rok rok force-pushed the fix_doctest_issues branch from c84c874 to 88da613 Compare January 31, 2026 09:33
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jan 31, 2026
@rok rok force-pushed the fix_doctest_issues branch from 88da613 to 6482c71 Compare January 31, 2026 09:38
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 31, 2026
@rok rok force-pushed the fix_doctest_issues branch from 6482c71 to dcbca14 Compare January 31, 2026 14:10
@rok rok force-pushed the fix_doctest_issues branch from dcbca14 to 130bfa4 Compare January 31, 2026 16:49
@rok
Copy link
Member Author

rok commented Jan 31, 2026

Thanks for the review @jorisvandenbossche ! Could you take another look before the merge?

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 31, 2026
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants