Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5c43465
Variant tools
mapleFU May 9, 2025
ec7d9e0
Merge branch 'main' of https://github.com/apache/arrow into variant-c…
mapleFU May 12, 2025
a4599d8
metadata logic impl
mapleFU May 12, 2025
34c1d2c
add some value interfaces
mapleFU May 12, 2025
1083a16
Merge branch 'main' into variant-cpp-decoder-tools
mapleFU May 13, 2025
ad585f2
Add basic tests (will failed)
mapleFU May 13, 2025
225b39b
Fix all primitive type tests( time, uuid not included)
mapleFU May 13, 2025
80a37ba
skeleton for object parsing ( bug might exists )
mapleFU May 13, 2025
fc4b721
eliminate duplicate code
mapleFU May 13, 2025
e8cdad7
Basic implement array (test not runned)
mapleFU May 13, 2025
34f546e
Finish code of uuid, complete some tests
mapleFU May 14, 2025
3566dfd
Cleanup for review
mapleFU May 14, 2025
54681c4
continue cleanup
mapleFU May 14, 2025
7759b03
Try to fix lint
mapleFU May 14, 2025
31fc7df
Address some comments, fix and test NestedObject problem
mapleFU May 14, 2025
15b12f2
Fix object handling, and refactor methods ( needs rethink it )
mapleFU May 14, 2025
bbce69c
Minor comments
mapleFU May 14, 2025
0c96946
Merge branch 'main' into variant-cpp-decoder-tools
mapleFU May 14, 2025
6454bb7
Trying to using scope resolution operator to fix ci
mapleFU May 14, 2025
9560023
Try to fix CI
mapleFU May 14, 2025
365329f
Revert stupid file name change
mapleFU May 15, 2025
cf9c4ad
refactor metadata and read u32le (bug exists)
mapleFU May 15, 2025
9b52d0b
VariantMetadata use u32 rather than i32; minor bug fix
mapleFU May 15, 2025
6c9c66d
optimize the case when metadata key is unique
mapleFU May 15, 2025
5361500
Apply cr suggestions
mapleFU May 16, 2025
7628110
Refactor with heavier value
mapleFU May 16, 2025
1b31d42
More comments for the code interface
mapleFU May 16, 2025
a83f8cc
change str to view
mapleFU May 16, 2025
17a0637
Revert toString return view firstly
mapleFU May 17, 2025
01ec5ea
Fix ci
mapleFU May 17, 2025
925a062
Add basic test and enhance interface for timestamp and uuid type
mapleFU May 19, 2025
4630680
Enhancement
mapleFU May 23, 2025
e6c5963
cleanup some constant using
mapleFU May 23, 2025
261cde1
Fix the logic for signed shift
mapleFU May 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/src/parquet/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ set(PARQUET_SRCS
statistics.cc
stream_reader.cc
stream_writer.cc
types.cc)
types.cc
variant.cc)

if(ARROW_HAVE_RUNTIME_AVX2)
# AVX2 is used as a proxy for BMI2.
Expand Down Expand Up @@ -382,7 +383,8 @@ add_parquet_test(internals-test
public_api_test.cc
size_statistics_test.cc
statistics_test.cc
types_test.cc)
types_test.cc
variant_test.cc)

set_source_files_properties(public_api_test.cc PROPERTIES SKIP_UNITY_BUILD_INCLUSION ON)

Expand Down
9 changes: 9 additions & 0 deletions cpp/src/parquet/test_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,15 @@ std::string get_bad_data_dir() {
return ss.str();
}

std::string get_variant_dir() {
// PARQUET_TEST_DATA should point to ARROW_HOME/cpp/submodules/parquet-testing/data
// so need to reach one folder up to access the "variant" folder.
std::string data_dir(get_data_dir());
std::stringstream ss;
ss << data_dir << "/../variant";
return ss.str();
}

std::string get_data_file(const std::string& filename, bool is_good) {
std::stringstream ss;

Expand Down
1 change: 1 addition & 0 deletions cpp/src/parquet/test_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ class ParquetTestException : public parquet::ParquetException {

const char* get_data_dir();
std::string get_bad_data_dir();
std::string get_variant_dir();

std::string get_data_file(const std::string& filename, bool is_good = true);

Expand Down
Loading
Loading