GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders

[jonkeane]

Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.

• GitHub Issue: [R] AWS SDK fails to build on one of CRAN's M1 builders  #43735

[jonkeane]

@github-actions crossbow submit test-r-install-local

[github-actions]

⚠️ GitHub issue #43735 has been automatically assigned in GitHub to PR creator.

[github-actions]

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd

Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c

Task	Status
test-r-install-local

[jonkeane]

@github-actions crossbow submit test-r-macos-as-cran

[github-actions]

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a

Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11

Task	Status
test-r-macos-as-cran

[jonkeane]

@github-actions crossbow submit test-r-macos-as-cran

[github-actions]

Revision: b75dd5945183896854d40862f834975c6fbba534

Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e

Task	Status
test-r-macos-as-cran

[jonkeane]

@github-actions crossbow submit test-r-macos-as-cran

[github-actions]

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb

Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2

Task	Status
test-r-macos-as-cran

[jonkeane]

@github-actions crossbow submit test-r-macos-as-cran

[github-actions]

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8

Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6

Task	Status
test-r-macos-as-cran

[jonkeane]

The R version failure is resolved in #43737

[kou]

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?

arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940 in 49be60f

	set(GRPC_C_FLAGS "${EP_C_FLAGS}")
	set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}")
	if(NOT MSVC)
	# Negate warnings that gRPC cannot build under
	# See https://github.com/grpc/grpc/issues/29417
	string(APPEND
	GRPC_C_FLAGS
	" -Wno-attributes"
	" -Wno-format-security"
	" -Wno-unknown-warning-option")
	string(APPEND
	GRPC_CXX_FLAGS
	" -Wno-attributes"
	" -Wno-format-security"
	" -Wno-unknown-warning-option")
	endif()
	set(GRPC_CMAKE_ARGS
	"${EP_COMMON_CMAKE_ARGS}"
	"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
	"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"

[jonkeane]

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!

[jonkeane]

@github-actions crossbow submit -g r

[github-actions]

Revision: 5e80a72

Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061

Task	Status
r-binary-packages
test-r-arrow-backwards-compatibility
test-r-clang-sanitizer
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-debian-gcc-release-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-opensuse155
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-r-sanitizer

[kou]

Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?

set(AWSSDK_COMMON_CMAKE_ARGS
    ${EP_COMMON_CMAKE_ARGS}
    -DCMAKE_C_FLAGS=${AWS_C_FLAGS}
    -DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}
    ...

[jonkeane]

@github-actions crossbow submit test-r-macos-as-cran

[github-actions]

Revision: 625a847

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3

Task	Status
test-r-macos-as-cran

[jonkeane]

The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.