GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty#14744
GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty#14744jorisvandenbossche merged 2 commits intoapache:masterfrom daattali:patch-1
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
daattali
changed the title
|
Edited title |
|
Unfortunately, the upgraded version of rlang has different (better!) error messages, and so there are test failures on CI as our testthat snapshots need updating too. @daattali - would you mind either updating them, or allowing me to push to your fork and I'll make those updates myself? |
|
The "Allow edits by maintainers" box is checked, you should be able to edit |
thisisnic
left a comment
thisisnic
left a comment
There was a problem hiding this comment.
LGTM, thanks for flagging this up and submitting the PR!
thisisnic
left a comment
thisisnic
left a comment
There was a problem hiding this comment.
LGTM, thanks for flagging this up and submitting the PR!
|
Benchmark runs are scheduled for baseline = a594e38 and contender = fde7b93. fde7b93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
5 participants
The function rlang::check_dots_empty() is used in this package. That function only became available in rlang version 1.0.0, so that version should be specified as the minimum