ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week#12515
ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week#12515rok wants to merge 2 commits intoapache:masterfrom
Conversation
rok
changed the title
There was a problem hiding this comment.
nit: is there any point templating on Unit when it's apparently always weeks (and doesn't seem to make sense for any other unit)?
There was a problem hiding this comment.
Good point! I originally wanted to use Ceil/Floor/RoundTimePoint but then changed the design and forgot this there. Will fix.
|
@lidavidm I rebased to see if appveyor issue goes away. |
|
@rok I think it's conda-forge/abseil-cpp-feedstock#25 (comment) |
Yeah I think it was that indeed. |
|
I think we can ignore these CI failures for now, merging. |
|
Benchmark runs are scheduled for baseline = b16329e and contender = 6907398. 6907398 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
Benchmark runs are scheduled for baseline = b16329e and contender = 6907398. 6907398 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
This is to resolve ARROW-15680.