[R] CRAN packaging checklist for version 19.0.1.1

[amoeba]

Describe the bug, including details regarding any error messages, version, and platform.

The rationale for this release is #45949.

Packaging Checklist for CRAN Release

For a high-level overview of the Arrow release process see the Apache Arrow Release Management Guide.

Before the Arrow Release Candidate Is Created

• Create a GitHub issue entitled [R] CRAN packaging checklist for version X.Y.Z and copy this checklist to the issue.
• Review deprecated functions to advance their deprecation status, including removing preprocessor directives that no longer apply (search for ARROW_VERSION_MAJOR in r/src).
• Evaluate the status of any failing nightly tests and nightly packaging builds. These checks replicate most of the checks that CRAN runs, so we need them all to be passing or to understand that the failures may (though won't necessarily) result in a rejection from CRAN.
• Check current CRAN check results.
• Ensure the contents of the README are accurate and up to date.
• Run urlchecker::url_check() on the R directory at the release candidate.
  commit. Ignore any errors with badges as they will be removed in the CRAN release branch.
• Polish NEWS but do not update version numbers (this is done automatically later). You can find commits by, for example, git log --oneline <sha of last release>..HEAD | grep "\[R\]".
• For major releases, prepare content for social media highlighting new features.

Wait for the release candidate to be created.

After the Arrow Release Candidate Has Been Created

• Create a CRAN-release branch from the release candidate commit, name the new branch maint-X.Y.Z-r and push to upstream.

Prepare and Check Package That Will Be Released to CRAN

• git fetch upstream && git checkout maint-X.Y.Z-r && git clean -f -d.
• Run make build. This copies Arrow C++ into tools/cpp, prunes some unnecessary components, and runs R CMD build to generate the source tarball. Because this will install the package, you will need to ensure that the version of Arrow C++ available to the configure script is the same as the version that is vendored into the R package (e.g., you may need to unset ARROW_HOME).
• devtools::check_built("arrow_X.Y.Z.tar.gz") locally.

Wait for Arrow Release Vote

• Release vote passed

Generate R Package to Submit to CRAN

• If the release candidate commit updated, rebase the CRAN release branch on that commit.
• Pick any commits that were made to main since the release commit that were needed to fix CRAN-related submission issues identified in the above steps.
• Remove badges from README.md.
• Run urlchecker::url_check() on the R directory.
• Create a PR entitled WIP: [R] Verify CRAN release-X.Y.Z-rcX. Add a comment @github-actions crossbow submit --group r to run all R crossbow jobs against the CRAN-specific release branch.
• Run Rscript tools/update-checksums.R <libarrow version> to download the checksums for the pre-compiled binaries from the ASF artifactory into the tools directory.
• Regenerate arrow_X.Y.Z.tar.gz (i.e., make build).

Check Binary Arrow C++ Distributions Specific to the R Package

• Upload the .tar.gz to win-builder (r-devel only) and confirm with Jon (who will automatically receive an email about the results) that the check is clean.
• Upload the .tar.gz to macOS Builder and confirm that the check is clean.
• Check install.packages("arrow_X.Y.Z.tar.gz") on Ubuntu and ensure that the hosted binaries are used.
• devtools::check_built("arrow_X.Y.Z.tar.gz") locally one more time (for luck).

Submit Package to CRAN

This step must be done by the current package maintainer.

• Upload arrow_X.Y.Z.tar.gz to the CRAN submit page.
• Confirm the submission email.

Wait for CRAN to Accept the Submission

• CRAN has accepted the submission.
• Tag the tip of the CRAN-specific release branch with r-universe-release.
• Add a new line to the matrix in the backwards compatability job.
• (patch releases only) Update the package version in ci/scripts/PKGBUILD, r/DESCRIPTION, and r/NEWS.md.
• (CRAN-only releases) Rebuild news page with pkgdown::build_news() and submit a PR to the asf-site branch of the docs site with the contents of arrow/r/docs/news/index.html replacing the current contents of arrow-site/docs/r/news/index.html.
• (CRAN-only releases) Bump the version number in r/pkgdown/assets/versions.json, and update this on the the asf-site branch of the docs site too..
• Review the packaging checklist template and update as needed.
• Wait for CRAN-hosted binaries on the CRAN package page to reflect the new version.
• Post already-prepared content to social media.
  • Use Bryce's script for contributor calculation.

Post-Release Tasks

• Update NEWS.md on main

Component(s)

R

[jonkeane]

I think we actually want this to be 19.0.1.1 so we can use the 19.0.1 libarrow binaries

[amoeba]

Ah, right. Changed the title.

[jonkeane]

Commits to pull:

• 629e05f (remove libs after linkining)
• 7e3b991 (remove libs after linkining, follow on)
• 34a984c (non-api calls)
• 48c0bbb (for m1 mac issues, cmake minimum version)

[jonkeane]

Ok, the open PRs are all done ^^^ are the 4 commits we need to cherry pick (I think that's all of them at least!). Do you still have time to do the patch release stuff @amoeba ?

[amoeba]

Hey @jonkeane, Re:

Do you still have time to do the patch release stuff

I do. I'll get started on that now.

[amoeba]

I submitted to winbuilder and macbuilder (release, devel) and tested installation on Ubuntu from pre-build binaries. Waiting on winbuilder/macbuilder and then we should be good to go.

[amoeba]

Hi @jonkeane, both macbuilders look good. If Winbuilder comes back clean, the final tarball is at https://files.brycemecum.com/arrow_19.0.1.1.tar.gz for you to submit to CRAN when you have a moment.

[jonkeane]

🙏 Thanks!

Winbuilder has a warning about symbols still: https://win-builder.r-project.org/rvH7wT4irAKs/00check.log

* checking compiled code ... WARNING
File 'arrow/libs/x64/arrow.dll':
  Found '_ZSt4cerr', possibly from 'std::cerr' (C++)
    Objects: '../windows/arrow-19.0.1/lib/x64-ucrt/libarrow.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libarrow_bundled_dependencies.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libthrift.a',
      '../windows/arrow-19.0.1/lib/x64/libarrow.a',
      '../windows/arrow-19.0.1/lib/x64/libarrow_bundled_dependencies.a',
      '../windows/arrow-19.0.1/lib/x64/libthrift.a'
  Found '_ZSt4cout', possibly from 'std::cout' (C++)
    Objects: '../windows/arrow-19.0.1/lib/x64-ucrt/libarrow.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libarrow_bundled_dependencies.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libaws-cpp-sdk-core.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libparquet.a',
      '../windows/arrow-19.0.1/lib/x64/libarrow.a',
      '../windows/arrow-19.0.1/lib/x64/libarrow_bundled_dependencies.a',
      '../windows/arrow-19.0.1/lib/x64/libaws-cpp-sdk-core.a',
      '../windows/arrow-19.0.1/lib/x64/libparquet.a'
  Found '_assert', possibly from 'assert' (C)
    Objects: '../windows/arrow-19.0.1/lib/x64/libnghttp2.a',
      '../windows/arrow-19.0.1/lib/x64/libssh2.a'
  Found '_exit', possibly from '_exit' (C)
    Objects: '../windows/arrow-19.0.1/lib/i386/libbrotlienc.a',
      '../windows/arrow-19.0.1/lib/i386/libbz2.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libcrypto.a',
      '../windows/arrow-19.0.1/lib/x64/libcrypto.a'
  Found 'abort', possibly from 'abort' (C), 'runtime' (Fortran)
    Objects: '../windows/arrow-19.0.1/lib/x64-ucrt/libarrow.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libarrow_acero.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libarrow_bundled_dependencies.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libaws-c-common.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libaws-cpp-sdk-core.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libaws-cpp-sdk-transfer.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libnghttp2.a',
      '../windows/arrow-19.0.1/lib/x64/libarrow.a',
      '../windows/arrow-19.0.1/lib/x64/libarrow_acero.a',
      '../windows/arrow-19.0.1/lib/x64/libarrow_bundled_dependencies.a',
      '../windows/arrow-19.0.1/lib/x64/libaws-c-common.a',
      '../windows/arrow-19.0.1/lib/x64/libaws-cpp-sdk-core.a',
      '../windows/arrow-19.0.1/lib/x64/libaws-cpp-sdk-transfer.a',
      '../windows/arrow-19.0.1/lib/x64/libnghttp2.a'
  Found 'exit', possibly from 'exit' (C), 'stop' (Fortran)
    Objects: '../windows/arrow-19.0.1/lib/x64-ucrt/libbrotlienc.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libbz2.a',
      '../windows/arrow-19.0.1/lib/x64/libbrotlienc.a',
      '../windows/arrow-19.0.1/lib/x64/libbz2.a'
  Found 'rand', possibly from 'rand' (C)
    Objects:
      '../windows/arrow-19.0.1/lib/x64-ucrt/libaws-cpp-sdk-core.a',
      '../windows/arrow-19.0.1/lib/x64-ucrt/libthrift.a',
      '../windows/arrow-19.0.1/lib/x64/libaws-cpp-sdk-core.a',
      '../windows/arrow-19.0.1/lib/x64/libthrift.a'

Compiled code should not call entry points which might terminate R nor
write to stdout/stderr instead of to the console, nor use Fortran I/O
nor system RNGs nor [v]sprintf.

See 'Writing portable packages' in the 'Writing R Extensions' manual.

[amoeba]

Ah, I guess that makes sense. I'm guessing we need to re-prepare the Windows build, I'll look into that.