Describe the bug, including details regarding any error messages, version, and platform.
The upgrade from lintr 3.1.2 to 3.2.0 brought up some changes due to some linters being added as required.
When we tried to fix CI (due to cyclocomp not being available anymore) we started getting several failures:
Error: Error: Not lint free
R/arrow-info.R:87:5: style: [return_linter] Use implicit return behavior; explicit return() is not needed.
return(FALSE)
^~~~~~
R/arrow-info.R:95:5: style: [return_linter] Use implicit return behavior; explicit return() is not needed.
return(FALSE)
^~~~~~
R/arrow-info.R:103:5: style: [return_linter] Use implicit return behavior; explicit return() is not needed.
return(FALSE)
^~~~~~
R/arrow-info.R:111:5: style: [return_linter] Use implicit return behavior; explicit return() is not needed.
return(FALSE)
^~~~~~
R/arrow-info.R:119:5: style: [return_linter] Use implicit return behavior; explicit return() is not needed.
return(FALSE)
^~~~~~
R/arrow-info.R:127:5: style: [return_linter] Use implicit return behavior; explicit return() is not needed.
return(FALSE)
^~~~~~
R/arrow-info.R:135:5: style: [return_linter] Use implicit return behavior; explicit return() is not needed.
return(FALSE)
^~~~~~
R/dplyr-arrange
or
tests/testthat/test-dplyr-collapse.R:146:7: style: [commented_code_linter] Remove commented code.
# filter(dbl > 2) %>%
^~~~~~~~~~~~~~~~~~~
tests/testthat/test-dplyr-collapse.R:147:7: style: [commented_code_linter] Remove commented code.
# select(chr, int, lgl) %>%
^~~~~~~~~~~~~~~~~~~~~~~~~
tests/testthat/test-dplyr-collapse.R:148:7: style: [commented_code_linter] Remove commented code.
# mutate(twice = int * 2L) %>%
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
tests/testthat/test-dplyr-collapse.R:149:7: style: [commented_code_linter] Remove commented code.
# group_by(lgl) %>%
^~~~~~~~~~~~~~~~~
tests/testthat/test-dplyr-collapse.R:150:7: style: [commented_code_linter] Remove commented code.
# summarize(total = sum(int, na.rm = TRUE)) %>%
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In addition: Warning message:
We should update lintr to the latest version and fix the linting failures.
We did temporarily pin here: #45524
Component(s)
R, Developer Tools
Describe the bug, including details regarding any error messages, version, and platform.
The upgrade from lintr 3.1.2 to 3.2.0 brought up some changes due to some linters being added as required.
When we tried to fix CI (due to cyclocomp not being available anymore) we started getting several failures:
or
We should update
lintrto the latest version and fix the linting failures.We did temporarily pin here: #45524
Component(s)
R, Developer Tools