Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView#6380
Merged
alamb merged 1 commit intoapache:masterfrom Sep 17, 2024
Merged
Conversation
alamb
force-pushed
the
alamb/remove_string_view_warning
branch
from
791fc20 to
1e029dc
Compare
alamb
changed the title
Member
|
Do you intend to leave in the warnings about ListView and LargeListView? arrow-rs/arrow-schema/src/datatype.rs Lines 297 to 299 in 704f90b arrow-rs/arrow-schema/src/datatype.rs Lines 312 to 314 in 704f90b |
Contributor
Author
Unfortunately I think they are still largely unimplemented (tracked by #5375) @Kikkon has some work here #5501 but needs someone to help review it |
Contributor
Author
|
Thanks for the reviews @Xuanwo and @kylebarron |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6163
Rationale for this change
As I was reviewing #6368 I came across a warning about Utf8View being not completely supported which was added in #5470 by @XiangpengHao when we began the implementation
Given these types are now supported across most of this crate I think this warning is no longer relevant
What changes are included in this PR?
Remove warning in comments
Are there any user-facing changes?
Doc changes, no functional changes