Skip to content

Add compare to ArrowNativeTypeOp#3070

Merged
tustvold merged 3 commits intoapache:masterfrom
tustvold:add-total-cmp
Nov 10, 2022
Merged

Add compare to ArrowNativeTypeOp#3070
tustvold merged 3 commits intoapache:masterfrom
tustvold:add-total-cmp

Conversation

@tustvold
Copy link
Copy Markdown
Contributor

@tustvold tustvold commented Nov 9, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

Noted whilst reviewing apache/datafusion#4133, adding this would allow DataFusion's ScalarValue and other downstreams to use the exact same comparison logic.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 9, 2022
@tustvold tustvold changed the title Add total_cmp to ArrowNativeTypeOp Add compare to ArrowNativeTypeOp Nov 10, 2022
@tustvold tustvold marked this pull request as ready for review November 10, 2022 01:49
@tustvold
Copy link
Copy Markdown
Contributor Author

I have confirmed this has no impact on benchmarks

@tustvold tustvold merged commit e44cb5b into apache:master Nov 10, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented Nov 10, 2022

Benchmark runs are scheduled for baseline = 5fb3033 and contender = e44cb5b. e44cb5b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants