Fix calling get_client in BigQueryHook.table_exists#9916
Merged
Conversation
… the defauly connection id.
boring-cyborg
Bot
added
the
provider:google
Contributor
Author
|
@turbaszek I foolishly deleted my branch for this fix so had to resubmit the PR. Would you mind reviewing again? |
turbaszek
approved these changes
Jul 21, 2020
turbaszek
left a comment
turbaszek
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks @nathadfield !
blcksrx
approved these changes
Jul 22, 2020
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the get_client method in hook.table_exists should specify the PROJECT_ID.
Closes: #9900
Description above provides context of the change