Skip to content

improve type hinting for celery provider #9762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 4 commits into from
Jul 11, 2020
Merged

improve type hinting for celery provider #9762

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49a0c0b
improve type hinting for celery provider
morrme Jul 11, 2020
4b2ec47
fix linter errors
morrme Jul 11, 2020
01bcf33
correct import sort
morrme Jul 11, 2020
a77ef6c
Update celery_queue.py
morrme Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions airflow/providers/celery/sensors/celery_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
# specific language governing permissions and limitations
# under the License.

from typing import Any, Dict, Optional

from celery.app import control

from airflow.sensors.base_sensor_operator import BaseSensorOperator
Expand All @@ -36,16 +38,16 @@ class CeleryQueueSensor(BaseSensorOperator):
@apply_defaults
def __init__(
self,
celery_queue,
target_task_id=None,
celery_queue: str,
target_task_id: Optional[str] = None,
*args,
**kwargs):
**kwargs) -> None:

super().__init__(*args, **kwargs)
self.celery_queue = celery_queue
self.target_task_id = target_task_id

def _check_task_id(self, context):
def _check_task_id(self, context: Dict[str, Any]) -> bool:
"""
Gets the returned Celery result from the Airflow task
ID provided to the sensor, and returns True if the
Expand All @@ -60,7 +62,7 @@ def _check_task_id(self, context):
celery_result = ti.xcom_pull(task_ids=self.target_task_id)
return celery_result.ready()

def poke(self, context):
def poke(self, context: Dict[str, Any]) -> bool:

if self.target_task_id:
return self._check_task_id(context)
Expand Down