Skip to content

Fix failing test in DagCode #9565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Jun 29, 2020
Merged

Fix failing test in DagCode #9565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/models/test_dagcode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def _write_two_example_dags(self):
return [bash_dag, xcom_dag]

@conf_vars({('core', 'store_dag_code'): 'True'})
@patch("airflow.models.dag.settings.STORE_DAG_CODE", True)
def _write_example_dags(self):
example_dags = make_example_dags(example_dags_module)
for dag in example_dags.values():
Expand All @@ -66,6 +67,7 @@ def test_sync_to_db(self):

self._compare_example_dags(example_dags)

@conf_vars({('core', 'store_dag_code'): 'True'})
def test_bulk_sync_to_db(self):
"""Dg code can be bulk written into database."""
example_dags = make_example_dags(example_dags_module)
Expand All @@ -76,6 +78,7 @@ def test_bulk_sync_to_db(self):

self._compare_example_dags(example_dags)

@conf_vars({('core', 'store_dag_code'): 'True'})
def test_bulk_sync_to_db_half_files(self):
"""Dg code can be bulk written into database."""
example_dags = make_example_dags(example_dags_module)
Expand Down Expand Up @@ -135,6 +138,8 @@ def _compare_example_dags(self, example_dags):
self.assertEqual(result.source_code, source_code)

@conf_vars({('core', 'store_dag_code'): 'True'})
@patch("airflow.models.dag.settings.STORE_DAG_CODE", True)
@patch("airflow.models.dagcode.STORE_DAG_CODE", True)
def test_code_can_be_read_when_no_access_to_file(self):
"""
Test that code can be retrieved from DB when you do not have access to Code file.
Expand All @@ -152,6 +157,7 @@ def test_code_can_be_read_when_no_access_to_file(self):
self.assertIn(test_string, dag_code)

@conf_vars({('core', 'store_dag_code'): 'True'})
@patch("airflow.models.dag.settings.STORE_DAG_CODE", True)
def test_db_code_updated_on_dag_file_change(self):
"""Test if DagCode is updated in DB when DAG file is changed"""
example_dag = make_example_dags(example_dags_module).get('example_bash_operator')
Expand Down