Refactor BigQuery operators#8858
Conversation
4c3b966 to
99faa55
Compare
99faa55 to
416365e
Compare
There was a problem hiding this comment.
Should we raise exception when user provide mutully exclussive parameters e.g. table_resource and source_uris?
There was a problem hiding this comment.
I agree. the behaviour is a bit undefined if wrong combination of parameters is specified. If table_resources is undefined and schema_fields are defined and source_objects and bucket are, I am not sure what happens here. I think all the "superfluous" combinations where same data is provided by different means should result in exception
There was a problem hiding this comment.
I've added an exception
There was a problem hiding this comment.
No idea, we've never discussed when we will deprecate such things
There was a problem hiding this comment.
I agree. the behaviour is a bit undefined if wrong combination of parameters is specified. If table_resources is undefined and schema_fields are defined and source_objects and bucket are, I am not sure what happens here. I think all the "superfluous" combinations where same data is provided by different means should result in exception
387991c to
603ea3d
Compare
603ea3d to
173563e
Compare
173563e to
bfedd51
Compare
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.