[AIRFLOW-6978] Add PubSubPullOperator#7613
Closed
ANiteckiP wants to merge 26 commits into
Closed
Conversation
ANiteckiP
changed the title
7 tasks
potiuk
reviewed
Mar 5, 2020
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Nice ! Only one question/comment for empty arrays
|
|
||
| return ret | ||
|
|
||
| def _default_message_callback( |
| :ref:`howto/operator:PubSubPullSensor` | ||
|
|
||
| .. seealso:: | ||
| If you don't want to wait for at least one message to come, use Operator instead: |
| :type max_messages: int | ||
| :param return_immediately: If True, instruct the PubSub API to return | ||
| immediately if no messages are available for delivery. | ||
| :param return_immediately: |
Member
There was a problem hiding this comment.
Here too! I love the detailed explanations!
Contributor
|
Will you squash all commits? |
ANiteckiP
changed the title
Contributor
Author
|
WIP: turned out I've missed some docs to be updated! |
Contributor
|
Aw... this is WIP. :) I haven't noticed |
turbaszek
reviewed
Mar 7, 2020
…ceivedMessage objects.
Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
Co-Authored-By: Tomek Urbaszek <turbaszek@gmail.com>
turbaszek
approved these changes
Mar 16, 2020
ANiteckiP
force-pushed
the
AIRFLOW-6978-pubsub-pull-operator
branch
from
fb6239f to
5c5a74a
Compare
ANiteckiP
changed the title
Member
|
Done in #7766 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PubSubPullOperator - a non-blocking equivalent to Add PubSubPullSensor.
These two share most of functionality but ultimately serve different purpose - while existing PubSubPullSensor will block the pipeline until it receives a message, new PubSubPullOperator can be used to check for new messages opportunistically.
Issue link: AIRFLOW-6978
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.