Make JWTRefreshMiddleware extensible via BaseAuthManager.get_jwt_refresh_middleware() - #70783
Open
stephen-bracken wants to merge 1 commit into
Open
Make JWTRefreshMiddleware extensible via BaseAuthManager.get_jwt_refresh_middleware()#70783stephen-bracken wants to merge 1 commit into
JWTRefreshMiddleware extensible via BaseAuthManager.get_jwt_refresh_middleware()#70783stephen-bracken wants to merge 1 commit into
Conversation
boring-cyborg
Bot
added
area:API
stephen-bracken
force-pushed
the
make-jwt-extendible
branch
from
July 30, 2026 21:39
0fb0bdd to
9502fe9
Compare
stephen-bracken
changed the title
JWTRefreshMiddleware extensible via BaseAuthManager.get_jwt_refresh_middleware()`
stephen-bracken
changed the title
JWTRefreshMiddleware extensible via BaseAuthManager.get_jwt_refresh_middleware()`JWTRefreshMiddleware extensible via BaseAuthManager.get_jwt_refresh_middleware()
stephen-bracken
force-pushed
the
make-jwt-extendible
branch
3 times, most recently
from
July 30, 2026 22:56
474ce7b to
7655032
Compare
stephen-bracken
marked this pull request as ready for review
July 30, 2026 23:38
stephen-bracken
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar,
shubhamraj-git and
vincbeck
as code owners
July 30, 2026 23:38
vincbeck
reviewed
Jul 31, 2026
stephen-bracken
force-pushed
the
make-jwt-extendible
branch
3 times, most recently
from
July 31, 2026 19:11
16198fd to
3a89840
Compare
Contributor
|
CI is failing |
stephen-bracken
force-pushed
the
make-jwt-extendible
branch
6 times, most recently
from
August 1, 2026 16:29
a8c2ae1 to
3dc4d12
Compare
Contributor
Author
|
I've updated edit: updated |
stephen-bracken
force-pushed
the
make-jwt-extendible
branch
5 times, most recently
from
August 1, 2026 17:48
4133591 to
87b198d
Compare
stephen-bracken
force-pushed
the
make-jwt-extendible
branch
from
August 4, 2026 09:56
87b198d to
908b21e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #70720
Make JWTRefreshMiddleware extensible via BaseAuthManager.get_jwt_refresh_middleware()
By moving the
JWTRefreshMiddlewareinitialisation toBaseAuthManager.get_jwt_refresh_middleware(), this allows auth managers to override the JWTRefreshMiddleware behaviour by inheriting from it and using the inherited class in get_fastapi_middlewares instead.By factoring out the
_set_new_token()method fromdispatch(), this gives an interface for the inherited token refresh middleware to alter the behaviour of the middleware when setting the tokens.Also adds the
airflow.api_fastapi.app.request_cookie_is_secure()helper to standardise setting HTTP secure cookiesWas generative AI tooling used to co-author this PR?