Skip to content

Validate AppflowBaseOperator source after template rendering #70482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mitre88 wants to merge 2 commits into from
+26 −3
Closed

Validate AppflowBaseOperator source after template rendering #70482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3beb7a9
Validate AppflowBaseOperator source after template rendering
mitre88 Jul 27, 2026
f3f6749
Add test proving a templated Appflow source passes validation after r…
mitre88 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/amazon/src/airflow/providers/amazon/aws/operators/appflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ def __init__(
**kwargs,
) -> None:
super().__init__(**kwargs)
if source is not None and source not in SUPPORTED_SOURCES:
raise ValueError(f"{source} is not a supported source (options: {SUPPORTED_SOURCES})!")
self.filter_date = filter_date
self.flow_name = flow_name
self.source = source
Expand All @@ -96,6 +94,8 @@ def __init__(
self.wait_for_completion = wait_for_completion

def execute(self, context: Context) -> None:
if self.source is not None and self.source not in SUPPORTED_SOURCES:
raise ValueError(f"{self.source} is not a supported source (options: {SUPPORTED_SOURCES})!")
self.filter_date_parsed: datetime | None = (
datetime.fromisoformat(self.filter_date) if self.filter_date else None
)
Expand Down
24 changes: 24 additions & 0 deletions providers/amazon/tests/unit/amazon/aws/operators/test_appflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,30 @@ def test_run(appflow_conn, ctx, waiter_mock):
appflow_conn.describe_flow_execution_records.assert_called_once()


def test_unsupported_source_fails_at_execute_time():
operator = AppflowRunOperator(
task_id=TASK_ID,
source="not-a-source",
flow_name=FLOW_NAME,
)
with pytest.raises(ValueError, match="not-a-source is not a supported source"):
operator.execute({})


@pytest.mark.db_test
def test_templated_source_passes_validation_after_rendering(appflow_conn, ctx, waiter_mock):
operator = AppflowRunOperator(
task_id=TASK_ID,
source="{{ var.value.appflow_source }}",
flow_name=FLOW_NAME,
poll_interval=0,
)
# Template rendering replaces the Jinja expression with the resolved value before execute.
operator.source = SOURCE
operator.execute(ctx)
appflow_conn.start_flow.assert_called_once_with(flowName=FLOW_NAME)


@pytest.mark.db_test
def test_run_full(appflow_conn, ctx, waiter_mock):
operator = AppflowRunFullOperator(**DUMP_COMMON_ARGS)
Expand Down
1 change: 0 additions & 1 deletion scripts/ci/prek/validate_operators_init_exemptions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
# Fixing a class (moving template-field validation/transformation out of __init__ into
# execute()) MUST remove its entry in the same PR — the hook fails on stale entries.
# Burn-down tracked at https://github.com/apache/airflow/issues/70296
providers/amazon/src/airflow/providers/amazon/aws/operators/appflow.py::AppflowBaseOperator
providers/amazon/src/airflow/providers/amazon/aws/operators/emr.py::EmrAddStepsOperator
providers/amazon/src/airflow/providers/amazon/aws/operators/neptune.py::NeptuneStartDbClusterOperator
providers/amazon/src/airflow/providers/amazon/aws/operators/neptune.py::NeptuneStopDbClusterOperator
Expand Down