Replace AirflowException with ValueError in ProduceToTopicOperator - #70351
Replace AirflowException with ValueError in ProduceToTopicOperator#70351FrankYang0529 wants to merge 1 commit into
Conversation
shahar1
left a comment
There was a problem hiding this comment.
Apparently #70333 was opened earlier and addresses the problem more precisely.
One thing in mind - here you tried to address two issues in one PR (validate_operators_init_exemption.txt + known_airflow_execptions) - I prefer to handle each separtely.
Feel free to tackle the other operators (there are still plenty), or to turn this PR into addressing the known_airflow_exceptions part once the other is merged.
|
I will turn this one into addressing the known_airflow_exceptions part after #70333 is merged. |
c6e42a0 to
3555991
Compare
shahar1
left a comment
There was a problem hiding this comment.
We might need to take an intermediate step of creating an exception class that derives from both AirflowException and ValueError, because it will break the retry mechanism that is based on detecting the exception type.
It had been discussed in the past but was put on hold, I'll try to revive this discussion.
Signed-off-by: PoAn Yang <payang@apache.org>
3555991 to
8667cd6
Compare
Based on
CLAUDE.md, the community is actively reducing AirflowException usage. Replaceraise AirflowException(...)withraise ValueError(...)in ProduceToTopicOperator.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.