Skip to content

[v3-3-test] Fix conn-fields check crash for nested provider packages (#70224) - #70279

Merged
potiuk merged 1 commit into
apache:v3-3-testfrom
astronomer:backport-c578603-v3-3-test
Jul 26, 2026
Merged

[v3-3-test] Fix conn-fields check crash for nested provider packages (#70224)#70279
potiuk merged 1 commit into
apache:v3-3-testfrom
astronomer:backport-c578603-v3-3-test

Conversation

@Lee-W

@Lee-W Lee-W commented Jul 23, 2026

Copy link
Copy Markdown
Member

(cherry picked from commit c578603)


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Lee-W

Lee-W commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

ideally, we shouldn't need this one but we might sometimes backport PR with provider changes and core-change. so backport this for preventing unexpected CI failure

@vatsrahul1001

Copy link
Copy Markdown
Contributor

@Lee-W looks like we have some conflicts

@Lee-W

Lee-W commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

opps, didn't notice it. let me fix it now

@Lee-W
Lee-W force-pushed the backport-c578603-v3-3-test branch from fe45a88 to 6198803 Compare July 24, 2026 09:35

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport verified against #70224 — the three atlassian/jira hunks and the common_prek_utils.py change are byte-identical to what merged on main, no cherry-pick drift.

Worth recording why this carries 4 of the 5 files: the omitted scripts/ci/prek/check_provider_yaml_files.py hunk was superseded on main by #70261, which replaced the KNOWN_SECOND_LEVEL_PATHS prefix-guessing with a real directory-tree walk via get_provider_base_dir_from_path(). That follow-up is already on v3-3-test, so porting #70224's version here would have regressed the resolver rather than fixed it. Dropping it is the right call.

The "ibm" entry still matters independently of the resolver — check_providers_subpackages_all_have_init.py and mypy_folder.py both still read that list, and providers/ibm/mq is a real nested package.


This review was drafted by an AI-assisted tool and
confirmed by an Airflow maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.

More on how Airflow handles maintainer review:
contributing-docs/05_pull_requests.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiuk
potiuk merged commit ce0fd3f into apache:v3-3-test Jul 26, 2026
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants