Skip to content

Fix HITL review showing altered agent output to reviewers#70070

Merged
guan404ming merged 3 commits into
apache:mainfrom
guan404ming:fix-hitl-review-xcom-double-deserialize
Jul 22, 2026
Merged

Fix HITL review showing altered agent output to reviewers#70070
guan404ming merged 3 commits into
apache:mainfrom
guan404ming:fix-hitl-review-xcom-double-deserialize

Conversation

@guan404ming

Copy link
Copy Markdown
Member

Why

The human review panel could display something different from what the agent actually produced: JSON-looking text was shown as a Python dict and "true" became True, so reviewers approved content that didn't match the task's real output.

How

  • Return XCom values as stored instead of re-parsing them in the HITL review plugin
  • Store plugin-written review data natively, matching how workers write XComs
  • Seed test XComs through the real worker write path so the mismatch is covered

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Fable 5)

@guan404ming
guan404ming marked this pull request as ready for review July 18, 2026 09:29
@guan404ming
guan404ming marked this pull request as draft July 18, 2026 11:05
@guan404ming
guan404ming force-pushed the fix-hitl-review-xcom-double-deserialize branch from c58e9d1 to 4209616 Compare July 18, 2026 12:44
@guan404ming
guan404ming marked this pull request as ready for review July 19, 2026 07:17

@gopidesupavan gopidesupavan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. and tested its fine..

@guan404ming
guan404ming force-pushed the fix-hitl-review-xcom-double-deserialize branch from 7053f6f to b7cc499 Compare July 22, 2026 02:14
@guan404ming

Copy link
Copy Markdown
Member Author

Thanks!

@guan404ming
guan404ming merged commit 42f68d4 into apache:main Jul 22, 2026
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants