Skip to content

Support sovereign console links#70001

Open
auyua9 wants to merge 1 commit into
apache:mainfrom
auyua9:fix/tpc-remaining-google-console-links
Open

Support sovereign console links#70001
auyua9 wants to merge 1 commit into
apache:mainfrom
auyua9:fix/tpc-remaining-google-console-links

Conversation

@auyua9

@auyua9 auyua9 commented Jul 17, 2026

Copy link
Copy Markdown

What changed

Completes the Sovereign Cloud / Trusted Partner Cloud console-link coverage introduced by #69805 for two remaining user-visible paths:

  • GCS Dag bundle browse URLs
  • Stackdriver external log viewer URLs

Both URLs now resolve their console domain through GoogleBaseHook.get_high_value_cookie_domain().

Tests

  • ruff format --check (changed files)
  • ruff check (changed files)
  • python3 -m compileall (changed files)
  • Targeted provider unit tests were added but could not be run locally because the installed uv is 0.10.8 while this checkout requires >=0.11.8; GitHub CI should run them in the project toolchain.

Was generative AI tooling used to co-author this PR?
  • Yes (Codex)

Important

🛠️ Maintainer triage note for @auyua9 · by @potiuk · 2026-07-18 15:46 UTC

Helpful heads-up from the maintainers — please address before this PR can be reviewed:

  • Pre-commit / static checks. See docs.

See the Pull Request quality criteria for details.

The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.

Automated triage — may be imperfect; a maintainer takes the next look.

@auyua9
auyua9 requested a review from shahar1 as a code owner July 17, 2026 07:40
@boring-cyborg boring-cyborg Bot added area:logging area:providers provider:google Google (including GCP) related issues labels Jul 17, 2026
@potiuk

potiuk commented Jul 20, 2026

Copy link
Copy Markdown
Member

@auyua9 This PR has a few issues that need to be addressed before it can be reviewed — please see our Pull Request quality criteria.

Issues found:

  • Pre-commit / static checks: Failing: CI image checks / Static checks. Run prek run --from-ref main --stage pre-commit locally to reproduce and fix.

Note: Your branch is 61 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • Fix each issue listed above.
  • Make sure static checks pass locally (prek run --from-ref main --stage pre-commit).
  • Mark the PR as "Ready for review" when you're done.

There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@auyua9 auyua9 changed the title fix(providers/google): support sovereign console links Support sovereign console links Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants