Add team_name tag to remaining multi-team metrics#69943
Conversation
ferruzzi
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! I left two small notes before I'll approve. Those were solid catches on the out of date docs, but they shouldn't be lumped in with this change. Split them into a new PR and I'll approve both.
badfdb0 to
9bcf752
Compare
|
Commented on the other PR; too far :P The Sorry for the confusion. |
Related to apache#68294 Added team_name tag to the following: connection_test.reaped connection_test.success connection_test.failed connection_test.hook_duration scheduler.executor_heartbeat_duration triggers.blocked_main_thread Added a team_name field to TestConnection class. This is to share team_name from the scheduler to connection test supervisor without changing the execution API.
9bcf752 to
e272ab0
Compare
|
My bad. I amended the commit to include only the relevant doc changes, lmk what you think |
As discussed in PR apache#69943, these doc changes are being moved to their own branch + PR instead of being attached to the other changes.
As discussed in PR apache#69943, these doc changes are being moved to their own branch + PR instead of being attached to the other changes.
ferruzzi
left a comment
There was a problem hiding this comment.
Approved pending CI passing
Should be able to close #68294 after merge.
Follow-up to #68367, #68589, #68593, #68594, #68599, #68108, and #68601.
Primary Changes
Added team_name tag to the following:
connection_test.reaped
connection_test.success
connection_test.failed
connection_test.hook_duration
scheduler.executor_heartbeat_duration
triggers.blocked_main_thread
Added a team_name field to TestConnection class. This is to share team_name from the scheduler to connection test supervisor without changing the execution API.
Excerpt from comment on closing issue:
The remaining scope was identified by @ferruzzi and is completed in this PR.
Remaining work (6)
Team-attributable, emit site has a team identity, but no team_name tag yet:
Two of these are more borderline than the others: scheduler.executor_heartbeat_duration
and triggers.blocked_main_thread are component-level (team-scoped executor /
team-scoped triggerer). They satisfy the signal list, but if those components are
considered "shared," they'd drop to non-team. The four connection_test.* rows are
clean Remaining items per the explicit "connection-test row" signal.
Was generative AI tooling used to co-author this PR?
Generated-by: Cursor (Auto) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.