Skip to content

UI: Share one tooltip root across Dag card run-state badges - #69927

Merged
bbovenzi merged 1 commit into
apache:mainfrom
yuseok89:perf/dags-list-share-run-state-badge-tooltip
Jul 16, 2026
Merged

UI: Share one tooltip root across Dag card run-state badges#69927
bbovenzi merged 1 commit into
apache:mainfrom
yuseok89:perf/dags-list-share-run-state-badge-tooltip

Conversation

@yuseok89

Copy link
Copy Markdown
Contributor

related: #69609

Each Dag card renders 4 run-state badges (added in #67242), each with its own Tooltip.Root. On a page of 50 cards that's up to 200 independent tooltip controllers, even though only one tooltip can be active at a time.

This applies the same pattern #69681 used for the recent-runs bar: one shared Tooltip.Root per card, with each badge as a Tooltip.Trigger, and the hovered badge's content resolved through Tooltip.Context. No visual change is expected.

Demo

Screen.Recording.2026-07-15.at.11.07.54.PM.mov

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    • Fable 5

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 15, 2026
@yuseok89
yuseok89 marked this pull request as ready for review July 15, 2026 22:03
@bbovenzi bbovenzi added this to the Airflow 3.3.1 milestone Jul 16, 2026
@bbovenzi bbovenzi added the backport-to-v3-3-test Backport to v3-3-test label Jul 16, 2026
@bbovenzi
bbovenzi merged commit 018f0c2 into apache:main Jul 16, 2026
170 checks passed
@bbovenzi

Copy link
Copy Markdown
Contributor

Thanks for helping with the dags list performance!

@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-3-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 018f0c2 v3-3-test

This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@pierrejeambrun pierrejeambrun removed the backport-to-v3-3-test Backport to v3-3-test label Jul 20, 2026
@pierrejeambrun

Copy link
Copy Markdown
Member

Depends on #67242 marked for 3.4.0. Updating the milestone of this PR to 3.4.0 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants