Preserve Dataform workflow invocation config#69161
Merged
shahar1 merged 1 commit intoJul 22, 2026
Merged
Conversation
shahar1
previously requested changes
Jun 30, 2026
shahar1
left a comment
Contributor
There was a problem hiding this comment.
@deepujain please note that you (or your operator) should include AI attribution in the PR as we state in the AI guidelines.
This PR, as well as others, are blocked from being merged until this is corrected.
Please be warned that creating additional PRs except for the 10 you've already created (listed below) without addressing the above might cause in a permanent block from Apache organization on GitHub.
List of PRs:
shahar1
approved these changes
Jul 22, 2026
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 22, 2026
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Preserve Dataform workflow invocation config
Summary
DataformHook.create_workflow_invocationnow normalizes dict-based workflow invocation payloads into aWorkflowInvocationproto before passing the request to the generated Dataform client.This keeps the public operator input unchanged while making nested proto fields explicit. In particular,
invocation_config.fully_refresh_incremental_tables_enabledis now covered by a regression test so full-refresh workflow invocation configs are not dropped at the hook boundary.Changes
providers/google/src/airflow/providers/google/cloud/hooks/dataform.py-- coerce dict workflow invocation payloads into the generatedWorkflowInvocationproto before calling the Dataform client.providers/google/tests/unit/google/cloud/hooks/test_dataform.py-- add a regression that passes the issue's dict-shapedinvocation_configand verifiesfully_refresh_incremental_tables_enabled=Truereaches the client request.Evidence it works
invocation_config.Test plan
uvx --from uv==0.11.21 uv run --project providers/google ruff format --check providers/google/src/airflow/providers/google/cloud/hooks/dataform.py providers/google/tests/unit/google/cloud/hooks/test_dataform.pyuvx --from uv==0.11.21 uv run --project providers/google ruff check providers/google/src/airflow/providers/google/cloud/hooks/dataform.py providers/google/tests/unit/google/cloud/hooks/test_dataform.pyAIRFLOW_HOME=/private/tmp/airflow-test-53843 uvx --from uv==0.11.21 uv run --project providers/google pytest providers/google/tests/unit/google/cloud/hooks/test_dataform.py::TestDataformHook::test_create_workflow_invocation providers/google/tests/unit/google/cloud/hooks/test_dataform.py::TestDataformHook::test_create_workflow_invocation_preserves_invocation_config_from_dict -xvs --with-db-initWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines
Fixes #53843