Close FTP file handles when a transfer raises - #69083
Merged
Merged
Conversation
retrieve_file and store_file opened a local file, then ran the FTP transfer before calling close(). When the transfer raised, the handle was never closed and leaked for the lifetime of the process. Wrapping the transfer in try/finally guarantees the handle we opened is closed on every path, while still leaving caller-supplied buffers open. closes: apache#69077
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
shahar1
approved these changes
Jun 27, 2026
henry3260
approved these changes
Jun 28, 2026
dabla
approved these changes
Jun 28, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
retrieve_file and store_file opened a local file, then ran the FTP transfer before calling close(). When the transfer raised, the handle was never closed and leaked for the lifetime of the process. Wrapping the transfer in try/finally guarantees the handle we opened is closed on every path, while still leaving caller-supplied buffers open. closes: apache#69077
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FTPHook.retrieve_fileandFTPHook.store_fileopened a local file and then ran the FTP transfer before callingclose(). If the transfer raised — a routine occurrence for network I/O — the handle was never closed and leaked for the lifetime of the process.Wrapping the transfer in
try/finallyguarantees the handle we opened is always closed, while still leaving a caller-supplied file-like buffer open (the method's existing contract). Adds regression tests for both methods that fail without the fix.closes: #69077
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines