Add team_name tags to Amazon executor metrics#69072
Merged
ferruzzi merged 2 commits intoJun 29, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
justinpakzad
force-pushed
the
multi-team-amazon-executor-metrics
branch
from
June 27, 2026 20:09
ba92729 to
1d227f1
Compare
justinpakzad
marked this pull request as ready for review
June 28, 2026 14:18
Contributor
Author
|
cc @ferruzzi |
Contributor
|
I'd like to have @o-nikolas opinion on this one |
o-nikolas
reviewed
Jun 29, 2026
justinpakzad
force-pushed
the
multi-team-amazon-executor-metrics
branch
from
June 29, 2026 21:03
1d227f1 to
10ba7aa
Compare
o-nikolas
approved these changes
Jun 29, 2026
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
team_nameas a tag on the task adoption duration metrics for Amazon executors in multi-team deployments.Metrics that now include team_name:
batch_executor.adopt_task_instances.durationecs_executor.adopt_task_instances.durationlambda_executor.adopt_task_instances.durationWhen there is no team (global executors, or older Airflow versions without multi-team support) the tag is omitted (prune_dict) and the metric behaves exactly as it does today.
Tests:
Added a parametrized test for each executor that checks the timer is called with the team name tag when a team is set, and with no tag when it is not. The tests are guarded with the
AIRFLOW_V_3_1_PLUSconstant for compatibility.related: #68996
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.