Move known_airflow_exceptions.txt out of scripts/ into generated/#69057
Merged
potiuk merged 1 commit intoJun 26, 2026
Merged
Conversation
The check-no-new-airflow-exceptions hook keeps its allowlist baseline in scripts/ci/prek/known_airflow_exceptions.txt. That file is touched by any PR that legitimately adds, removes, or moves a raise AirflowException -- typically provider or core changes that have nothing to do with dev tooling. Because it lived under scripts/, boring-cyborg matched it against the scripts/**/* glob and auto-applied area:dev-tools and, worse, backport-to-v3-3-test, triggering wrong automated backports of unrelated provider PRs. Move the generated allowlist to generated/known_airflow_exceptions.txt, which no boring-cyborg rule matches, so editing it no longer looks like a dev-tools change. The hook script reads/writes it from the repo-root generated/ directory; .txt files carry no license header, so nothing else changes.
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496 and
jscheffl
as code owners
June 26, 2026 20:08
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
1 task
shahar1
approved these changes
Jun 26, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 26, 2026
…nerated/ (apache#69057) The check-no-new-airflow-exceptions hook keeps its allowlist baseline in scripts/ci/prek/known_airflow_exceptions.txt. That file is touched by any PR that legitimately adds, removes, or moves a raise AirflowException -- typically provider or core changes that have nothing to do with dev tooling. Because it lived under scripts/, boring-cyborg matched it against the scripts/**/* glob and auto-applied area:dev-tools and, worse, backport-to-v3-3-test, triggering wrong automated backports of unrelated provider PRs. Move the generated allowlist to generated/known_airflow_exceptions.txt, which no boring-cyborg rule matches, so editing it no longer looks like a dev-tools change. The hook script reads/writes it from the repo-root generated/ directory; .txt files carry no license header, so nothing else changes. (cherry picked from commit 78263d0) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 26, 2026
…nerated/ (apache#69057) The check-no-new-airflow-exceptions hook keeps its allowlist baseline in scripts/ci/prek/known_airflow_exceptions.txt. That file is touched by any PR that legitimately adds, removes, or moves a raise AirflowException -- typically provider or core changes that have nothing to do with dev tooling. Because it lived under scripts/, boring-cyborg matched it against the scripts/**/* glob and auto-applied area:dev-tools and, worse, backport-to-v3-3-test, triggering wrong automated backports of unrelated provider PRs. Move the generated allowlist to generated/known_airflow_exceptions.txt, which no boring-cyborg rule matches, so editing it no longer looks like a dev-tools change. The hook script reads/writes it from the repo-root generated/ directory; .txt files carry no license header, so nothing else changes. (cherry picked from commit 78263d0) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
added a commit
that referenced
this pull request
Jun 29, 2026
…nerated/ (#69057) (#69060) The check-no-new-airflow-exceptions hook keeps its allowlist baseline in scripts/ci/prek/known_airflow_exceptions.txt. That file is touched by any PR that legitimately adds, removes, or moves a raise AirflowException -- typically provider or core changes that have nothing to do with dev tooling. Because it lived under scripts/, boring-cyborg matched it against the scripts/**/* glob and auto-applied area:dev-tools and, worse, backport-to-v3-3-test, triggering wrong automated backports of unrelated provider PRs. Move the generated allowlist to generated/known_airflow_exceptions.txt, which no boring-cyborg rule matches, so editing it no longer looks like a dev-tools change. The hook script reads/writes it from the repo-root generated/ directory; .txt files carry no license header, so nothing else changes. (cherry picked from commit 78263d0) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
…ache#69057) The check-no-new-airflow-exceptions hook keeps its allowlist baseline in scripts/ci/prek/known_airflow_exceptions.txt. That file is touched by any PR that legitimately adds, removes, or moves a raise AirflowException -- typically provider or core changes that have nothing to do with dev tooling. Because it lived under scripts/, boring-cyborg matched it against the scripts/**/* glob and auto-applied area:dev-tools and, worse, backport-to-v3-3-test, triggering wrong automated backports of unrelated provider PRs. Move the generated allowlist to generated/known_airflow_exceptions.txt, which no boring-cyborg rule matches, so editing it no longer looks like a dev-tools change. The hook script reads/writes it from the repo-root generated/ directory; .txt files carry no license header, so nothing else changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
check-no-new-airflow-exceptionshook keeps its allowlist baseline atscripts/ci/prek/known_airflow_exceptions.txt. That file is updated by any PR that legitimately adds, removes, or moves araise AirflowException— typically provider or core changes with nothing to do with dev tooling.Because it lived under
scripts/, boring-cyborg matched it against thescripts/**/*glob and auto-appliedarea:dev-toolsand — the real problem —backport-to-v3-3-test, triggering wrong automated backports of unrelated provider PRs (e.g. the false backport flagged on #69019).Fix
Move the generated allowlist to
generated/known_airflow_exceptions.txt. No boring-cyborg rule matchesgenerated/, so editing the baseline no longer looks like a dev-tools change and won't auto-label/backport. The hook script now reads/writes it from the repo-rootgenerated/directory (via the existingREPO_ROOT)..txtfiles carry no license header (noinsert-licensehook covers.txt), so nothing else changes.Pure rename + 4 path-reference updates in the hook script; verified the hook still passes and
--generatewrites to the new location.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines