prevent path traversal in s3 to sftp/ftp transfer destinations#68984
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
vincbeck
approved these changes
Jun 26, 2026
o-nikolas
reviewed
Jun 27, 2026
Signed-off-by: Samin061 <sam@bugqore.com>
o-nikolas
approved these changes
Jun 30, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3ToSFTPOperator and S3ToFTPOperator build the remote destination by concatenating S3 key suffixes returned by list_keys onto the configured sftp_path/ftp_path, so an object whose name contains ../ segments resolves outside that directory on the SFTP/FTP server and the upload lands wherever the server canonicalises it. Object names are arbitrary strings controlled by anyone who can write to the source bucket, so the resolved destination is validated to stay within the configured path before uploading, mirroring the existing gcs_to_sftp and gcs_to_samba guards.
Was generative AI tooling used to co-author this PR?