Skip to content

Document breaking-change changelog notes in provider docs skill#68738

Merged
shahar1 merged 1 commit into
apache:mainfrom
shahar1:improve-prepare-provider-docs-breaking-note
Jun 19, 2026
Merged

Document breaking-change changelog notes in provider docs skill#68738
shahar1 merged 1 commit into
apache:mainfrom
shahar1:improve-prepare-provider-docs-breaking-note

Conversation

@shahar1

@shahar1 shahar1 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Human Summary

While working on #68642, I've noticed that the skill didn't add notes on breaking changes (which are extremely important). This PR fixes it.

AI Summary

Click hereWhile preparing the 2026-06-16 provider documentation wave (#68642), two providers with breaking changes — `edge3` 4.0.0 (Edge execution-API `TaskInstanceDTO` schema change) and `common.ai` 0.5.0 (SQLToolset `allowed_tables` now enforced on queries) — got the `Breaking changes` bullet but no top-of-version `.. note::` explaining *what* breaks or *how* users should adapt.

The cause is in the prepare-providers-documentation skill: it instructed
the agent to add the .. note:: block only for the Airflow min-version
bump case. Yet every provider changelog.rst carries the standing
convention in its header — "only add notes … when there are some breaking
changes and you want to add an explanation to the users on how they are
supposed to deal with them"
— so a behavioural breaking change should
always get an explanatory note.

This updates the skill (Phase 4b rules and the incremental Phase 4 step) so
the .. note:: block covers both situations: the Airflow min-version bump
and every breaking classification, with the breaking-change note written
from the PR description and diff so readers learn how to react without
opening the PR.

Docs-only change to an agent skill; no runtime code affected.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4.8)

Generated-by: Claude Code (Opus 4.8) following the guidelines

The prepare-providers-documentation skill only told the agent to add a
top-of-version note for the Airflow min-version bump case, so a release
shipping a behavioural breaking change got the bullet but no explanation
of what breaks or how to adapt. The repository changelog convention asks
for exactly such an explanation whenever there is a breaking change, so
make the skill require it for every breaking classification.
@shahar1 shahar1 changed the title Require breaking-change explanation notes in provider docs skill Document breaking-change changelog notes in provider docs skill Jun 19, 2026
@shahar1 shahar1 merged commit 832ecf8 into apache:main Jun 19, 2026
63 checks passed
@shahar1 shahar1 deleted the improve-prepare-provider-docs-breaking-note branch June 19, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants