Fix backfill completion race#68729
Open
PrithviBadiga wants to merge 2 commits into
Open
Conversation
boring-cyborg
Bot
added
the
area:Scheduler
PrithviBadiga
force-pushed
the
prithvi/backfill-complete-race
branch
from
8ec4798 to
cfc9794
Compare
potiuk
added
the
ready for maintainer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a backfill completion race where a backfill could be marked complete before all associated work had reached a terminal state.
Updates:
_mark_backfills_completecheck unresolvedBackfillDagRunassociations rather than only unfinishedDagRun.backfill_idrowsdag_run_idonBackfillDagRunrows when a matching DagRun already exists or is in-flightThis keeps backfills open until all tracked backfill work has actually resolved.
This closes: #68721