SnowflakeHook: refactor static connection parameter construction#68597
Merged
potiuk merged 1 commit intoJun 26, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:snowflake
Contributor
Author
|
Please do not review this before PR #68549 is merged (if it is approved of course). These are 2 separate PRs as the thesis is slightly different and it also makes review easier. |
into dedicated helpers for connector options, workload identity, authentication, and network configuration. This simplifies the control flow, reduces method complexity, and improves separation of concerns without changing behavior.
SameerMesiah97
force-pushed
the
SnowflakeHook-Refactor-Conn-Params-Method
branch
from
June 25, 2026 14:45
0ba3504 to
28c5c43
Compare
SameerMesiah97
marked this pull request as ready for review
June 25, 2026 15:45
potiuk
approved these changes
Jun 26, 2026
Member
|
Nice! |
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
…pache#68597) into dedicated helpers for connector options, workload identity, authentication, and network configuration. This simplifies the control flow, reduces method complexity, and improves separation of concerns without changing behavior. Co-authored-by: Sameer Mesiah <smesiah971@gmail.com>
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change refactors static connection parameter construction in SnowflakeHook by extracting configuration-specific logic from
_get_static_conn_params()into dedicated helper methods.Connection parameter assembly has been decomposed into focused helpers responsible for base connection configuration, connector options, workload identity configuration, authentication configuration, and network configuration.
_get_static_conn_params()remains the single entrypoint for constructing cached connection parameters while delegating individual configuration domains to dedicated helpers.Rationale
_get_static_conn_params()had grown to encompass several distinct configuration responsibilities within a single method. Grouping related logic into dedicated helpers reduces method complexity, improves readability, and establishes clearer ownership boundaries for individual configuration paths.This structure makes future enhancements to authentication, workload identity, networking, and connector-specific configuration easier to implement and review independently.
Backwards Compatibility
This change is a refactor only and does not modify public APIs or runtime behavior. Connection parameter construction and authentication flows remain unchanged.