-
Notifications
You must be signed in to change notification settings - Fork 17.3k
feature/issue-68575: Add bundle_name to Dag
#68583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jroachgolf84
wants to merge
5
commits into
apache:main
Choose a base branch
from
jroachgolf84:feature/issue-68575
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5cf6a94
feature/issue-68575: Add bundle_name to Dag
jroachgolf84 f6575a9
feature/issue-68575: Updating serialization
jroachgolf84 2bf846f
feature/issue-68575: Adding bundle_name to get_serialized_fields
jroachgolf84 c66176d
feature/issue-68575: Fixing CI failures
jroachgolf84 daabbda
Merge branch 'main' into feature/issue-68575
jroachgolf84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -360,6 +360,16 @@ def test_dagbag_with_bundle_name(self, tmp_path): | |
| dagbag2 = DagBag(dag_folder=os.fspath(tmp_path)) | ||
| assert dagbag2.bundle_name is None | ||
|
|
||
| def test_dag_with_bundle_name(self, tmp_path): | ||
| """Test that bundle_name is attached to each Dag in the DagBag.""" | ||
| dagbag = DagBag(dag_folder=os.fspath(tmp_path), bundle_name="test_bundle") | ||
| for dag in dagbag.dags.values(): | ||
| assert dag.bundle_name == "test_bundle" | ||
|
|
||
| dagbag2 = DagBag(dag_folder=os.fspath(tmp_path)) | ||
| for dag in dagbag2.dags.values(): | ||
| assert dag.bundle_name is None | ||
|
|
||
|
Comment on lines
+363
to
+372
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should use a real path |
||
| def test_get_existing_dag(self, tmp_path, standard_example_dags_folder): | ||
| """ | ||
| Test that we're able to parse some example DAGs and retrieve them | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.