Remove redundant tests from airflow-core#68513
Merged
Merged
Conversation
Surfaced by two detectors (per-test coverage signatures + an AST whole-tree scan) and confirmed by reading each body, its decorators and the production code. Exact / near-exact duplicates (P5): - test_base_executor.py::test_state_generic — byte-identical to test_state_queued. - test_base_executor.py::TestCallbackSupport::test_local_executor_supports_callbacks_true — cross-file dup of test_local_executor.py's TestLocalExecutorCallbackSupport; LocalExecutor's flag belongs there. - test_base_job.py::test_base_job_respects_plugin_hooks — byte-identical to test_state_sysexit; tests nothing about plugin hooks (real coverage is test_base_job_respects_plugin_lifecycle). - test_kerberos_command.py::test_run_command_with_mode_standard — byte-identical to test_run_command; both assert the STANDARD default. - test_logging_config.py::test_empty_string_falls_back_to_default — subsumed by test_falsy_logging_class_path_falls_back_to_default, parametrized over ['', None]. Library-behaviour tests (P1) — attrs-generated dunders, no custom logic: - test_rollup_wait_policy.py::TestRepr (both repr tests) and test_wait_for_all_is_stateless exercise @attrs.define(frozen=True) __repr__/__eq__/ __hash__ on WaitForAll/MinimumCount, which define no custom dunders.
boring-cyborg
Bot
added
area:CLI
area:Executors-core
jscheffl
approved these changes
Jun 13, 2026
shahar1
changed the title
pgagnon
pushed a commit
to pgagnon/airflow
that referenced
this pull request
Jun 15, 2026
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Jun 16, 2026
dingo4dev
pushed a commit
to dingo4dev/airflow
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Summary
related: #68502, #68507
This PR removes tests that are either stdlib/3rd-party's concern, trivial attribute round-trip, or duplicated tests.
Summarizing table is in the "AI Summary".
AI Summary
Click Here
Candidates were surfaced by two detectors — per-test coverage signatures and an AST scan of the whole test tree (cross-file duplicates + dunder/stdlib + round-trip patterns) — and every one was confirmed by reading the test body, its decorators, and the production code before deletion.
Legend — patterns:
test_state_genericairflow-core/tests/unit/executors/test_base_executor.py:448test_state_queued(sameBaseExecutor.queued()call and the two assertions onrunning/event_buffer); only the name differs. Kepttest_state_queued.test_empty_string_falls_back_to_defaultairflow-core/tests/unit/logging/test_logging_config.py:60test_falsy_logging_class_path_falls_back_to_default, which is@parametrized over["", None]and already exercises the empty-string case with the identical assertion.TestCallbackSupport::test_local_executor_supports_callbacks_trueairflow-core/tests/unit/executors/test_base_executor.py:642test_local_executor.py::TestLocalExecutorCallbackSupport::test_supports_callbacks_flag_is_true(LocalExecutor(); assert supports_callbacks is True). LocalExecutor's flag belongs intest_local_executor.py; kept that copy.test_base_job_respects_plugin_hooksairflow-core/tests/unit/jobs/test_base_job.py:59test_state_sysexit(runssys.exit(0), assertsSUCCESS) — tests nothing about plugin hooks despite its name. Real plugin coverage is the separatetest_base_job_respects_plugin_lifecycle.test_run_command_with_mode_standardairflow-core/tests/unit/cli/commands/test_kerberos_command.py:124test_run_command— neither passes--mode, both assert theSTANDARDdefault. Adds no coverage beyondtest_run_command.TestRepr::test_wait_for_all_reprairflow-core/tests/unit/partition_mappers/test_rollup_wait_policy.py:109repr(WaitForAll()) == "WaitForAll()"—WaitForAllis@attrs.define(frozen=True)with no custom__repr__; this tests attrs' generated repr.TestRepr::test_minimum_count_reprairflow-core/tests/unit/partition_mappers/test_rollup_wait_policy.py:112repr(MinimumCount(5)) == "MinimumCount(n=5)"— attrs-generated repr, no custom__repr__on the class.TestPolicyConstruction::test_wait_for_all_is_statelessairflow-core/tests/unit/partition_mappers/test_rollup_wait_policy.py:53WaitForAll() == WaitForAll()and equal hashes —@attrs.define(frozen=True)auto-generates__eq__/__hash__for the field-less class; tests attrs, not airflow logic.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines