Fix WASB log source URLs to use storage account endpoint#68510
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
dabla
requested changes
Jun 23, 2026
Contributor
Author
|
hey, any news on this? |
dabla
approved these changes
Jul 16, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WASB task log handler currently reports remote log source URLs as:
https://<container>.blob.core.windows.net/<blob>That makes the container name look like the storage account. Log reads still work because they use
WasbHook, but the URL shown in the UI points at the wrong host.This PR builds the source URL from the Azure
BlobServiceClientinstead:primary_endpointwhen available.account_name, then to the old container-host format.Tests cover normal Azure endpoints, Azurite endpoints, SAS query/fragment removal, SAS-in-path removal, and fallback paths. The logging docs example now shows
account/container/blob.Tests:
uv run --project providers/microsoft/azure ruff check providers/microsoft/azure/src/airflow/providers/microsoft/azure/log/wasb_task_handler.py providers/microsoft/azure/tests/unit/microsoft/azure/log/test_wasb_task_handler.pyuv run --project providers/microsoft/azure pytest providers/microsoft/azure/tests/unit/microsoft/azure/log/test_wasb_task_handler.py -qgit diff --checkWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines