Remove redundant tests from Task SDK#68504
Open
shahar1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Summary
related: #68502.
This PR removes tests that are either stdlib/3rd-party's concern, trivial attribute round-trip, or duplicated tests.
Summarizing table is in the "AI Summary".
AI Summary
Click Here
Legend — patterns:
obj.field == value_just_passed_in)test_build_task_group_with_prefix_functionalitytest_build_task_group_with_prefix: same Dag structure, same 7 assertions, only the Dag name string and inline comments differtest_mask_secret_with_iterabletest_mask_secret_with_list: identical setupexample_dict = ["test"]and identical assertion — claims to test an iterable but uses the same listtest_mask_secret_with_listtest_mask_secret_with_objects, which already covers a list input alongside dict and string casestest_node_not_found_caught_as_key_errortest_node_not_found_is_subclass_of_key_error; if the class hierarchy is correct the catch is guaranteed by Python — testsexceptmechanics, not our codetest_node_not_found_caught_as_task_not_foundtest_node_not_found_is_subclass_of_task_not_found; tests Python's exception dispatch, not the exception class definitiontest_eq(WaitForAll)WaitForAllis a plain attrs class with no custom__eq__;WaitForAll() == WaitForAll()tests attrs-generated equality, not project logictest_hash_consistent(WaitForAll)hash(WaitForAll()) == hash(WaitForAll())tests attrs-generated__hash__, not project logictest_repr(WaitForAll)repr(WaitForAll()) == "WaitForAll()"tests attrs-generated__repr__with no custom repr logictest_stores_n(MinimumCount)MinimumCount(5).n == 5— pure attribute round-trip on an attrs field, no computed value or transformationtest_eq_same_n(MinimumCount)MinimumCount(5) == MinimumCount(5)— attrs-generated value equality, not project logictest_hash_consistent(MinimumCount)hash(MinimumCount(5)) == hash(MinimumCount(5))— attrs-generated__hash__, not project logictest_repr(MinimumCount)repr(MinimumCount(5)) == "MinimumCount(n=5)"— attrs-generated repr, no custom logictest_explicit_valuesAssetAccessControl(...)and asserts each field equals what was passed in — pure round-trip, no transformation or validation exercisedTestTaskGroupGetItem::test_getitem_missing_is_key_errorNodeNotFoundsubclassesKeyError, so the siblingraises(NodeNotFound)already guarantees theraises(KeyError)catch — re-states a fact Python's class hierarchy enforcesTestDagGetItem::test_getitem_missing_is_key_errorDag.__getitem__test_override_dag_default_argstest_default_args(same Dag, sameTaskGroupdefault_args, same three owner assertions); only the name and docstring differWas generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines