fix(test_wasb.py): SAS token tests failing with azure-storage-blob 12.30.0#68490
Merged
Conversation
….30.0 Signed-off-by: PoAn Yang <payang@apache.org>
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
Lee-W
reviewed
Jun 13, 2026
Lee-W
reviewed
Jun 13, 2026
Lee-W
left a comment
Lee-W
left a comment
Member
There was a problem hiding this comment.
The solution here is not wrong. But I think https://github.com/apache/airflow/pull/68486/changes is a better design (rely on SDK)
1 task
Signed-off-by: PoAn Yang <payang@apache.org>
uranusjr
reviewed
Jun 13, 2026
Signed-off-by: PoAn Yang <payang@apache.org>
potiuk
approved these changes
Jun 13, 2026
pgagnon
pushed a commit
to pgagnon/airflow
that referenced
this pull request
Jun 15, 2026
….30.0 (apache#68490) * fix(test_wasb.py): SAS token tests failing with azure-storage-blob 12.30.0 Signed-off-by: PoAn Yang <payang@apache.org> * refactor: add SAS link and update test_sas_token_connection assertion Signed-off-by: PoAn Yang <payang@apache.org> * test: assert sas_token in conn.url Signed-off-by: PoAn Yang <payang@apache.org> --------- Signed-off-by: PoAn Yang <payang@apache.org>
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Jun 16, 2026
….30.0 (apache#68490) * fix(test_wasb.py): SAS token tests failing with azure-storage-blob 12.30.0 Signed-off-by: PoAn Yang <payang@apache.org> * refactor: add SAS link and update test_sas_token_connection assertion Signed-off-by: PoAn Yang <payang@apache.org> * test: assert sas_token in conn.url Signed-off-by: PoAn Yang <payang@apache.org> --------- Signed-off-by: PoAn Yang <payang@apache.org>
dingo4dev
pushed a commit
to dingo4dev/airflow
that referenced
this pull request
Jun 16, 2026
….30.0 (apache#68490) * fix(test_wasb.py): SAS token tests failing with azure-storage-blob 12.30.0 Signed-off-by: PoAn Yang <payang@apache.org> * refactor: add SAS link and update test_sas_token_connection assertion Signed-off-by: PoAn Yang <payang@apache.org> * test: assert sas_token in conn.url Signed-off-by: PoAn Yang <payang@apache.org> --------- Signed-off-by: PoAn Yang <payang@apache.org>
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_sas_token_connectionfails onazure-storage-blob==12.30.0: the test fixtures passed fake SAS tokens that get appended as a URL path segment, and 12.30.0 no longer echoes the path back inBlobServiceClient.urlfor known*.blob.core.windows.nethosts (it builds the URL from the netloc only).A SAS token is a query string, not a path. The old assertion only passed because the previous SDK reflected the path back in
.url. This switches the fixtures to a realistic SAS token / SAS URL and asserts the token lands in the URL query string, which is stable across SDK versions.closes: #68482
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude Code with Opus 4.8] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.