common.ai: Park approval reviews in awaiting_input on Airflow 3.3+#68489
Merged
Conversation
gopidesupavan
approved these changes
Jun 14, 2026
gopidesupavan
left a comment
gopidesupavan
left a comment
Member
There was a problem hiding this comment.
cool :) thats a really nice change.. need to catchup more on the actual pr
Member
|
seems tests not triggered ? |
Contributor
|
seems there are conflicts |
kaxil
force-pushed
the
commonai-approval-awaiting-input
branch
2 times, most recently
from
be41401 to
cfaf01f
Compare
LLMApprovalMixin (require_approval=True on LLMOperator/AgentOperator) now raises TaskAwaitingInput on Airflow 3.3+ so the task parks in the first-class awaiting_input state -- no trigger or triggerer involved -- matching the standard provider's HITLOperator. On older cores it falls back to deferring to HITLTrigger as before. The response deadline is enforced by the scheduler's awaiting_input timeout sweep on 3.3+. Because nothing upstream schema-validates params_input on the awaiting_input path (HITLTrigger did on the legacy path), execute_complete now enforces the string contract for reviewer-modified output and raises HITLTriggerEventError for non-string values. The AIRFLOW_V_3_3_PLUS flag this uses was added in apache-airflow-providers-common-compat 1.15.0; the dependency line is marked "# use next version" so the release manager bumps the floor at release time.
kaxil
force-pushed
the
commonai-approval-awaiting-input
branch
from
cfaf01f to
c7509c5
Compare
RulerChen
pushed a commit
to RulerChen/airflow
that referenced
this pull request
Jun 16, 2026
…pache#68489) LLMApprovalMixin (require_approval=True on LLMOperator/AgentOperator) now raises TaskAwaitingInput on Airflow 3.3+ so the task parks in the first-class awaiting_input state -- no trigger or triggerer involved -- matching the standard provider's HITLOperator. On older cores it falls back to deferring to HITLTrigger as before. The response deadline is enforced by the scheduler's awaiting_input timeout sweep on 3.3+. Because nothing upstream schema-validates params_input on the awaiting_input path (HITLTrigger did on the legacy path), execute_complete now enforces the string contract for reviewer-modified output and raises HITLTriggerEventError for non-string values. The AIRFLOW_V_3_3_PLUS flag this uses was added in apache-airflow-providers-common-compat 1.15.0; the dependency line is marked "# use next version" so the release manager bumps the floor at release time.
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLMApprovalMixin(require_approval=TrueonLLMOperator/AgentOperator) now raisesTaskAwaitingInputon Airflow 3.3+, parking the review in the first-classawaiting_inputstate (#68028) with no trigger or triggerer involved, matching the standard provider'sHITLOperator. On older cores it falls back to deferring toHITLTriggerunchanged, gated onAIRFLOW_V_3_3_PLUS.Why:
approval_timeouton 3.3+ with the same timeout-event semantics asHITLTrigger.airflow dags testresolvingawaiting_inputtasks interactively, review pipelines become runnable end to end locally. Verified in breeze with pydantic-ai's TestModel: the task parks inawaiting_input, an approval with reviewer-modified output resumes it, and the modified output flows downstream as the task result.One behavior fix rides along: on the legacy path
HITLTriggerschema-validatedparams_inputbefore resuming, but nothing does on the awaiting_input path (the Core API route validates chosen options and cardinality only).execute_completenow enforces the string contract for reviewer-modified output and raisesHITLTriggerEventErrorwitherror_type="validation"for non-string values. Previously on this path an API client could make the operator return a dict where the declared output contract isstr.The dependency floor moves to
apache-airflow-providers-common-compat>=1.15.0, the first release with theAIRFLOW_V_3_3_PLUSflag.