Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,10 @@ def proc(
if map_index := event.get("map_index"):
labels["map_index"] = str(map_index)

_transport.send(record, str(msg.get("event", "")), resource=self.resource, labels=labels)
try:
_transport.send(record, str(msg.get("event", "")), resource=self.resource, labels=labels)
except Exception:
_logger.warning("Failed to send log to Cloud Logging", exc_info=True)
return event

return (proc,)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,38 @@ def test_processors_skips_non_task_logger(self, mock_client, mock_get_creds_and_
assert result is event
mock_transport_type.return_value.send.assert_not_called()

@pytest.mark.skipif(not AIRFLOW_V_3_0_PLUS, reason="airflow.sdk.log only exists in Airflow 3+")
@mock.patch("airflow.providers.google.cloud.log.stackdriver_task_handler.get_credentials_and_project_id")
@mock.patch("airflow.providers.google.cloud.log.stackdriver_task_handler.gcp_logging.Client")
def test_processors_survives_transport_send_failure(
self, mock_client, mock_get_creds_and_project_id, caplog
):
"""Test that transport.send() failure does not crash the logging processor."""
mock_get_creds_and_project_id.return_value = ("creds", "project_id")

mock_transport_type = mock.MagicMock()
mock_transport_type.return_value.send.side_effect = RuntimeError("IAM permission denied")
with mock.patch("airflow.sdk.log.relative_path_from_logger", return_value="dag/task/1.log"):
io = StackdriverRemoteLogIO(
base_log_folder=self.local_log_location,
gcp_log_name="airflow",
transport_type=mock_transport_type,
)
proc = io.processors[0]

event = {
"event": "log message test",
"logger_name": "airflow.task",
"timestamp": "2026-06-30T00:00:00+09:00",
}
with caplog.at_level(logging.WARNING):
result = proc(mock.MagicMock(), "info", event)

# Ensure that it still returns the event
assert result is event
# Ensure that the error is logged
assert "Failed to send log to Cloud Logging" in caplog.text


@pytest.mark.usefixtures("clean_stackdriver_handlers")
@mock.patch("airflow.providers.google.cloud.log.stackdriver_task_handler.get_credentials_and_project_id")
Expand Down
Loading