[v3-2-test] fixed sort order for mapped task instances (#67551)#68164
Merged
Conversation
* fixed sort order for mapped task instances * Updated tests * Fixed pagination crash * Fixed comments * Fix duplicate order_by attributes in OpenAPI spec and SortParam description When `rendered_map_index` (and other keys like `run_after`, `logical_date`, `data_interval_start`, `data_interval_end`) are present in both `allowed_attrs` and `to_replace`, `dynamic_depends` was appending them twice to `all_attrs`, causing the generated `order_by` parameter description to list those attributes twice. This caused the `generate-openapi-spec` static check to fail. Fix: deduplicate `to_replace_attrs` by excluding keys already in `allowed_attrs` before building `all_attrs`. Update the committed OpenAPI spec to match. * Static check fix --------- (cherry picked from commit 94fa4d2) Co-authored-by: manipatnam <91188953+manipatnam@users.noreply.github.com> Co-authored-by: AI Assistant <bot@antigravity.dev>
1 task
boring-cyborg
Bot
added
area:API
jscheffl
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
jscheffl
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed sort order for mapped task instances
Updated tests
Fixed pagination crash
Fixed comments
Fix duplicate order_by attributes in OpenAPI spec and SortParam description
When
rendered_map_index(and other keys likerun_after,logical_date,data_interval_start,data_interval_end) are present in bothallowed_attrsand
to_replace,dynamic_dependswas appending them twice toall_attrs,causing the generated
order_byparameter description to list those attributestwice. This caused the
generate-openapi-specstatic check to fail.Fix: deduplicate
to_replace_attrsby excluding keys already inallowed_attrsbefore building
all_attrs. Update the committed OpenAPI spec to match.(cherry picked from commit 94fa4d2)
Co-authored-by: manipatnam 91188953+manipatnam@users.noreply.github.com
Co-authored-by: AI Assistant bot@antigravity.dev