[AIRFLOW-4824] Add charset handling for SqlAlchemy engine for MySqlHook#6816
Merged
Conversation
Airflow should handle various charsets for connections with MySQL dbs. This change allows to set charset in extra field of a connection when using SqlAlchemy engine.
Codecov Report
@@ Coverage Diff @@
## master #6816 +/- ##
==========================================
- Coverage 84.45% 84.31% -0.14%
==========================================
Files 676 676
Lines 38310 38317 +7
==========================================
- Hits 32354 32307 -47
- Misses 5956 6010 +54
Continue to review full report at Codecov.
|
TobKed
approved these changes
Dec 14, 2019
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…ok (apache#6816) Airflow should handle various charsets for connections with MySQL dbs. This change allows to set charset in extra field of a connection when using SqlAlchemy engine.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Airflow should handle various charsets for connections with MySQL dbs.
This change allows to set charset in extra field of a connection when
using SqlAlchemy engine.
Make sure you have checked all steps below.
Jira
Description
Airflow should handle various charsets for connections with MySQL dbs.
This change allows to set charset in extra field of a connection when
using SqlAlchemy engine.
Tests
test_get_uri in TestMySqlHookConn
Commits
Documentation