Bigquery proxy support#67218
Conversation
|
As an FYI, when testing in my environment the code was reformatted by Ruff which considerably expands the number of changes, if this is an issue, please let me know and I'll revert this |
|
Should be ready for review (assuming it passes the checks) |
|
@shahar1 can you review this when you get the chance? |
Could you please revert the extra formatting? It makes it hard to review, thanks! |
|
Figured that might be the case, I'll try and update the request to revert the formatting sometime either tomorrow or early next week |
|
I think I've moved over the functional changes without touching the rest of the formatting, I just need to confirm it still works in my env after this |
|
Just confirming the revised version still works as intended in my environment @shahar1 |
shahar1
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I have a couple of comments - there's some rework to be done, mainly to make the changes minimal and precise as much as possible.
If possible, I'd like to ask adding a Dag example + a screenshot that demonstrates that the Dag can run E2E. If you're unable to do so, please provide instructions for others to do so.
…d dialect + kwargs, revert unecessary client options change
|
Cut down unit tests, consolidated imports, reversed changes to method that wasn't needed, and added dialect / kwargs / timeout changes + tested to confirm everything was still working on my end obvs |
|
Need to rework the unit tests. Bugger. |
Adds support for supplying a HTTP / HTTPS proxy to the bigquery hook using any of
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Sonnet 4.6 following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.