Fix unhashable dict tag crashing triggerer metrics (#66353)#66354
Closed
jakubmatyszewski wants to merge 1 commit into
Closed
Fix unhashable dict tag crashing triggerer metrics (#66353)#66354jakubmatyszewski wants to merge 1 commit into
jakubmatyszewski wants to merge 1 commit into
Conversation
`get_metric_info` left a `dict` value under the `kwargs` tag, causing `TypeError: unhashable type: 'dict'` in OpenTelemetry's `_view_instrument_match` when building the attribute frozenset. Serialize non-empty filtered kwargs to `str` and drop the key when empty.
jakubmatyszewski
force-pushed
the
fix_triggerer_otel_typerror
branch
from
854da6c to
11e66a5
Compare
potiuk
added
the
ready for maintainer review
Contributor
|
This is already fixed in #67527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The triggerer crashes with a
TypeError: unhashable type: 'dict'when OpenTelemetry metrics are enabled.Root cause
The crash occurs because
Callback.get_metric_info()inairflow/models/callback.pycan return a tags dict containing a nested dict as a value (the "kwargs" key). OpenTelemetry's_view_instrument_match.pylater callsfrozenset(attributes.items())to build an aggregation key, which fails because dict values are not hashable.Fix
Serialize the remaining kwargs to a string, or drop them if empty.
How to reproduce
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.