Trigger unit tests on shared/*.py changes#64999
Merged
Merged
Conversation
Add shared/*.py pattern to ALL_SOURCE_FILES so changes that only touch the shared libraries (e.g., shared/timezones, shared/logging) trigger the unit test suite. Previously such changes were missed by selective checks because the shared/ folder was not part of the source files patterns, leading to skipped tests for changes that affect symlinked code in airflow-core, task-sdk, and providers.
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
vatsrahul1001
as code owners
bugraoz93
approved these changes
Apr 10, 2026
jscheffl
approved these changes
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Breeze selective checks so that changes to Python files under shared/ are treated as source changes and therefore trigger the unit test suite, addressing missed CI coverage for symlinked shared libraries consumed by core/SDK/providers.
Changes:
- Add
^shared/.*\.py$toALL_SOURCE_FILESmatching in selective checks. - Add a regression test ensuring a
shared/timezonesPython change triggersrun-unit-tests(andci-image-build).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
dev/breeze/src/airflow_breeze/utils/selective_checks.py |
Extends ALL_SOURCE_FILES to include Python files under shared/, enabling unit tests for shared-library code changes. |
dev/breeze/tests/test_selective_checks.py |
Adds a targeted test case asserting shared-library Python changes trigger unit tests. |
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 12, 2026
…4999) Add shared/*.py pattern to ALL_SOURCE_FILES so changes that only touch the shared libraries (e.g., shared/timezones, shared/logging) trigger the unit test suite. Previously such changes were missed by selective checks because the shared/ folder was not part of the source files patterns, leading to skipped tests for changes that affect symlinked code in airflow-core, task-sdk, and providers. (cherry picked from commit f13b713) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Contributor
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk
added a commit
that referenced
this pull request
Apr 12, 2026
…4999) (#65094) Add shared/*.py pattern to ALL_SOURCE_FILES so changes that only touch the shared libraries (e.g., shared/timezones, shared/logging) trigger the unit test suite. Previously such changes were missed by selective checks because the shared/ folder was not part of the source files patterns, leading to skipped tests for changes that affect symlinked code in airflow-core, task-sdk, and providers. (cherry picked from commit f13b713) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…4999) (#65094) Add shared/*.py pattern to ALL_SOURCE_FILES so changes that only touch the shared libraries (e.g., shared/timezones, shared/logging) trigger the unit test suite. Previously such changes were missed by selective checks because the shared/ folder was not part of the source files patterns, leading to skipped tests for changes that affect symlinked code in airflow-core, task-sdk, and providers. (cherry picked from commit f13b713) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…4999) (#65094) Add shared/*.py pattern to ALL_SOURCE_FILES so changes that only touch the shared libraries (e.g., shared/timezones, shared/logging) trigger the unit test suite. Previously such changes were missed by selective checks because the shared/ folder was not part of the source files patterns, leading to skipped tests for changes that affect symlinked code in airflow-core, task-sdk, and providers. (cherry picked from commit f13b713) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…4999) (#65094) Add shared/*.py pattern to ALL_SOURCE_FILES so changes that only touch the shared libraries (e.g., shared/timezones, shared/logging) trigger the unit test suite. Previously such changes were missed by selective checks because the shared/ folder was not part of the source files patterns, leading to skipped tests for changes that affect symlinked code in airflow-core, task-sdk, and providers. (cherry picked from commit f13b713) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…4999) (#65094) Add shared/*.py pattern to ALL_SOURCE_FILES so changes that only touch the shared libraries (e.g., shared/timezones, shared/logging) trigger the unit test suite. Previously such changes were missed by selective checks because the shared/ folder was not part of the source files patterns, leading to skipped tests for changes that affect symlinked code in airflow-core, task-sdk, and providers. (cherry picked from commit f13b713) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
shared/*.pypattern toALL_SOURCE_FILESin selective checks so that changes that only touch the shared libraries (e.g.shared/timezones,shared/logging) trigger the unit test suite.Previously, such changes were missed by selective checks because the
shared/folder was not part of any source-file pattern. As a result, unit tests were skipped for changes that affect symlinked code consumed byairflow-core,task-sdk, and providers.Includes a new test case
Shared library python changes trigger unit testscovering this behavior.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.6 (1M context) following the guidelines